# 5.3+ build broken, see compile log

- Thread: https://externals.io/message/41681
- Original archive: https://news-web.php.net/php.internals/41681
- Started by Pierre Joye on 2008-11-05T10:31:07+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #41681 — Pierre Joye — 2008-11-05T10:31:07+00:00

URL: https://externals.io/message/41681#41681

Hi,

A commit in the last 24 hours breaks the builds:

d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(2735) :
error C2036: 'void *' : unknown size
d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(10445) :
error C2036: 'void *' : unknown size
d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(17792) :
error C2036: 'void *' : unknown size

Full log:

http://phpfi.com/373993

Cheers,
-- 
Pierre
http://blog.thepimp.net | http://www.libgd.org

---

## #41685 — Gregory Beaver — 2008-11-05T15:30:42+00:00

URL: https://externals.io/message/41681#41685 · In reply to: #41681

Pierre Joye wrote:
> Hi,
> 
> A commit in the last 24 hours breaks the builds:
> 
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(2735) :
> error C2036: 'void *' : unknown size
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(10445) :
> error C2036: 'void *' : unknown size
> d:\php-sdk\snap_5_3\vc9\x86\snap53_vc9\zend\zend_vm_execute.h(17792) :
> error C2036: 'void *' : unknown size

Hi,

Unrelated to this windows compilation problem (thanks Felipe for the
quick fix), I'm concerned to see that I missed an example of opcode
modification.  We can't modify opcodes directly because of opcode
caches.  This code needs to be refactored slightly to either create the
needed stuff in compile-time and pass it in with ZEND_OP_DATA or one of
the unused op1/op2 (best) or run-time estrndup finagling (not so good).

Thanks for pointing this out Pierre.

Greg

---

## #41689 — Stanislav Malyshev — 2008-11-05T18:07:08+00:00

URL: https://externals.io/message/41681#41689 · In reply to: #41685

Hi!

> Unrelated to this windows compilation problem (thanks Felipe for the
> quick fix), I'm concerned to see that I missed an example of opcode
> modification.  We can't modify opcodes directly because of opcode

Runtime opcode modification is definitely a bad idea. This needs to be 
fixed.
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com