# str_getcsv - Thread: https://externals.io/message/41293 - Original archive: https://news-web.php.net/php.internals/41293 - Started by Steve Hanselman on 2008-10-20T20:43:18+00:00 - Messages: 9 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #41293 — Steve Hanselman — 2008-10-20T20:43:18+00:00 URL: https://externals.io/message/41293#41293 Can anybody suggest a reason why this has never moved from main to php_5_2 or php_5_3? It was added to MAIN in dec '06 Steve The information contained in this email is intended for the personal and confidential use of the addressee only. It may also be privileged information. If you are not the intended recipient then you are hereby notified that you have received this document in error and that any review, distribution or copying of this document is strictly prohibited. If you have received this communication in error, please notify Brendata immediately on: +44 (0)1268 466100, or email 'technical@brendata.co.uk' Brendata (UK) Ltd Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX UK Registered Office as above. Registered in England No. 2764339 See our current vacancies at www.brendata.co.uk --- ## #41294 — Hannes Magnusson — 2008-10-20T20:46:27+00:00 URL: https://externals.io/message/41293#41294 · In reply to: #41293 > Can anybody suggest a reason why this has never moved from main to php_5_2 or php_5_3? I did wonder the same months ago, but noone seemed to care, and I had no use for it myself so I never bothered merging it :) > The information contained in this email is intended for the personal and confidential use Are you high? -Hannes --- ## #41296 — Steve Hanselman — 2008-10-20T21:03:15+00:00 URL: https://externals.io/message/41293#41296 · In reply to: #41294 If it's not stupid question, what is the main branch for? Presumably the other branches aren't just branched from this at a point in time or we'd have this in there. High? Nah, just chilled after a glass or two of wine. Can't beat a good corporate disclaimer! Steve --- ## #41297 — Ilia Alshanetsky — 2008-10-20T21:07:43+00:00 URL: https://externals.io/message/41293#41297 · In reply to: #41294 > On Mon, Oct 20, 2008 at 22:43, Steve Hanselman > wrote: > > […] > > I did wonder the same months ago, but noone seemed to care, and I had > no use for it myself so I never bothered merging it :) The functionality is rather handy (I think), I would +1 for its addition to the 5.3 branch. Ilia Alshanetsky --- ## #41298 — Lukas Kahwe Smith — 2008-10-20T21:33:41+00:00 URL: https://externals.io/message/41293#41298 · In reply to: #41297 > > > > > […] > > The functionality is rather handy (I think), I would +1 for its > addition to the 5.3 branch. if someone commits it before alpha3 its fine by me. regards, Lukas Kahwe Smith mls@pooteeweet.org --- ## #41300 — johannes@php.net — 2008-10-20T23:19:04+00:00 URL: https://externals.io/message/41293#41300 · In reply to: #41296 > If it's not stupid question, what is the main branch for? Presumably > the other branches aren't just branched from this at a point in time > or we'd have this in there. The "main" branch? PHP_5_X are the "stable" branches, "HEAD" is the development branch (at least in theory ...) So stuff is added to HEAD and merged bacxk when it's stable enough and need (and somebody cares) +1 from me, though... johannes --- ## #41310 — Steve Hanselman — 2008-10-21T17:32:59+00:00 URL: https://externals.io/message/41293#41310 · In reply to: #41300 > The "main" branch? PHP_5_X are the "stable" branches, "HEAD" is the > development branch (at least in theory ...) So stuff is added to HEAD > and merged bacxk when it's stable enough and need (and somebody cares) > > +1 from me, though... > > johannes Now, if we could work the phrase "namespaces" into this somehow we'd probably have this in HEAD within a few days..... On a serious note, there seem to have been quite a few commits to MAIN over time, so I wonder what else is lurking there that could be useful? If nobody else is doing this then I'm happy to build a diff, What's involved in getting a commit account for CVS or is it easier to just email a diff set to somebody (in which case, who?) Steve The information contained in this email is intended for the personal and confidential use of the addressee only. It may also be privileged information. If you are not the intended recipient then you are hereby notified that you have received this document in error and that any review, distribution or copying of this document is strictly prohibited. If you have received this communication in error, please notify Brendata immediately on: +44 (0)1268 466100, or email 'technical@brendata.co.uk' Brendata (UK) Ltd Nevendon Hall, Nevendon Road, Basildon, Essex. SS13 1BX UK Registered Office as above. Registered in England No. 2764339 See our current vacancies at www.brendata.co.uk --- ## #41311 — Pierre Joye — 2008-10-21T18:26:23+00:00 URL: https://externals.io/message/41293#41311 · In reply to: #41310 hi, > > […] > > Now, if we could work the phrase "namespaces" into this somehow we'd probably have this in HEAD within a few days..... > > On a serious note, there seem to have been quite a few commits to MAIN over time, so I wonder what else is lurking there that could be useful? > > If nobody else is doing this then I'm happy to build a diff, What's involved in getting a commit account for CVS or is it easier to just email a diff set to somebody (in which case, who?) Easiest (and safest) is: - to create a patch (cvs diff -up) - open a feature request (a bug :) in bugs.php.net, with a link to the patch - post it in this thread as well with a ref to the bug # Doing so will make sure that your patch will not be lost in the archive :) After having provided a couple of patches, you may consider a CVS account request. Thanks for your work! Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org --- ## #41618 — Felipe Pena — 2008-11-02T22:41:47+00:00 URL: https://externals.io/message/41293#41618 · In reply to: #41298 Hello, 2008/10/20 Lukas Kahwe Smith : > > > > > […] > > > if someone commits it before alpha3 its fine by me. > Done! I've added a test and it's failing in HEAD though. We need check it, and to see what's the real behavior expected. A notable difference between the HEAD and 5.x fgetcsv implementation, is that in HEAD the delimiter, enclosure and escape can have more than 1 char. Then the following is valid: // string input[, string delimiter[, string enclosure[, string escape]]] var_dump(str_getcsv('<>foo++<><>[]<>bar<>', '[]', '<>', '++')); Should we really accept that? -- Regards, Felipe Pena.