# run-tests.php esacapeshellarg, portability

- Thread: https://externals.io/message/39809
- Original archive: https://news-web.php.net/php.internals/39809
- Started by Pierre Joye on 2008-08-10T15:31:41+00:00
- Messages: 1
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #39809 — Pierre Joye — 2008-08-10T15:31:41+00:00

URL: https://externals.io/message/39809#39809

hi!

While fixing broken tests (linux or win), I found that shell arguments
are manually escaped. Using escapeshellargs is more portable and avoid
duplicate tests only to fix shell argument issues (& usage for
example).

Here is a patch to add escapeshellarg usage:

http://pierre.libgd.org/patches/runtests_5_3_escapeshellarg.patch.txt

A couple of tests need changes, like:

inisetting="foo"

will become

inisetting=foo

or

inisetting=""

to

inisetting=


Please test the patch or let me know if you have any objection :)

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org