# Focus on HEAD - Thread: https://externals.io/message/38103 - Original archive: https://news-web.php.net/php.internals/38103 - Started by Steph Fox on 2008-06-08T14:23:17+00:00 - Messages: 21 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #38103 — Steph Fox — 2008-06-08T14:23:17+00:00 URL: https://externals.io/message/38103#38103 Hi Andrei, all, Can we please have a clear, on-list explanation of the reason(s) the non-Unicode mode blocks can't be cleared out of core in CVS HEAD today? As in, if (!UG(unicode)).... Thanks, - Steph --- ## #38104 — Andrei Zmievski — 2008-06-08T15:48:43+00:00 URL: https://externals.io/message/38103#38104 · In reply to: #38103 Is there a patch that does that? I'm fine with removing these checks. -Andrei Steph Fox wrote: > > Hi Andrei, all, > > > > Can we please have a clear, on-list explanation of the reason(s) the > non-Unicode mode blocks can't be cleared out of core in CVS HEAD today? > > As in, if (!UG(unicode)).... > > Thanks, > > - Steph --- ## #38105 — Steph Fox — 2008-06-08T15:52:29+00:00 URL: https://externals.io/message/38103#38105 · In reply to: #38104 > Is there a patch that does that? I'm fine with removing these checks. If there isn't already, there soon will be :) Did you want to review it prior to commit? - Steph --- ## #38106 — Andrei Zmievski — 2008-06-08T21:54:59+00:00 URL: https://externals.io/message/38103#38106 · In reply to: #38105 Sure. Steph Fox wrote: > > > […] > > If there isn't already, there soon will be :) > > Did you want to review it prior to commit? > > - Steph --- ## #38121 — Steph Fox — 2008-06-09T17:55:24+00:00 URL: https://externals.io/message/38103#38121 · In reply to: #38106 Hi all, Andrei doesn't have time to review this lot (covers ext/standard). Could someone please check it for clangers? Thanks, - Steph > > Sure. > > Steph Fox wrote: > > […] --- ## #38122 — Felipe Pena — 2008-06-09T18:49:03+00:00 URL: https://externals.io/message/38103#38122 · In reply to: #38121 Hi all Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu: > Hi all, > > Andrei doesn't have time to review this lot (covers ext/standard). Could > someone please check it for clangers? > > Thanks, > > - Steph Here's the rest (ext/* and main/*): http://felipe.ath.cx/diff/unicode-check.diff - Removed: - if (UG(unicode)) - unicode_semantics() function - pcre_cache_entry.unicode_mode - Changed: - ZEND_STR_TYPE -> IS_UNICODE - convert_to_text -> convert_to_unicode - convert_to_text_ex -> convert_to_unicode_ex MySQL part: http://felipe.ath.cx/diff/mysql-unicode-check.diff http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff (removed the ini_set("unicode.semantics") checks) MySQL guys, the non-unicode tests can be removed? (those that uses SKIPIF...) > > > […] > -- > > -- Regards, Felipe Pena. --- ## #38123 — Steph Fox — 2008-06-10T00:52:14+00:00 URL: https://externals.io/message/38103#38123 · In reply to: #38122 Hey Felipe, 'Scuse top-posting, my >>s have let me down again. Two things: first, I did in ext/standard exactly as you did elsewhere (you know this already but the rest don't). Second, I already sent the MySQL guys some bits and pieces for their tests. Oh, and third - if nobody gets back to us by Friday over these patches we'll just commit :) Don't know about Felipe's larger corner, but I tested mine to death already. - Steph ----- Original Message ----- From: "Felipe Pena" To: "Steph Fox" Cc: "Andrei Zmievski" ; "internals" Sent: Monday, June 09, 2008 7:49 PM Subject: Re: [PHP-DEV] Re: Focus on HEAD Hi all Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu: > Hi all, > > Andrei doesn't have time to review this lot (covers ext/standard). Could > someone please check it for clangers? > > Thanks, > > - Steph Here's the rest (ext/* and main/*): http://felipe.ath.cx/diff/unicode-check.diff - Removed: - if (UG(unicode)) - unicode_semantics() function - pcre_cache_entry.unicode_mode - Changed: - ZEND_STR_TYPE -> IS_UNICODE - convert_to_text -> convert_to_unicode - convert_to_text_ex -> convert_to_unicode_ex MySQL part: http://felipe.ath.cx/diff/mysql-unicode-check.diff http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff (removed the ini_set("unicode.semantics") checks) MySQL guys, the non-unicode tests can be removed? (those that uses SKIPIF...) > > > […] > -- > > -- Regards, Felipe Pena. --- ## #38127 — Stanislav Malyshev — 2008-06-10T07:04:48+00:00 URL: https://externals.io/message/38103#38127 · In reply to: #38123 Hi! > Oh, and third - if nobody gets back to us by Friday over these patches > we'll just commit :) Don't know about Felipe's larger corner, but I > tested mine to death already. I think it would also be nice to tag it before the change, just in case. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com --- ## #38128 — Antony Dovgal — 2008-06-10T07:51:23+00:00 URL: https://externals.io/message/38103#38128 · In reply to: #38127 > Hi! > > > […] > > I think it would also be nice to tag it before the change, just in case. Good point, we always tag it before committing large patches. -- Wbr, Antony Dovgal --- ## #38132 — Steph Fox — 2008-06-10T11:05:10+00:00 URL: https://externals.io/message/38103#38132 · In reply to: #38127 > > […] > > I think it would also be nice to tag it before the change, just in case. Oooh, exciting stuff :) - Steph > -- > Stanislav Malyshev, Zend Software Architect > stas@zend.com http://www.zend.com/ > (408)253-8829 MSN: stas@zend.com --- ## #38138 — Stanislav Malyshev — 2008-06-10T13:01:16+00:00 URL: https://externals.io/message/38103#38138 · In reply to: #38122 > - Changed: > - ZEND_STR_TYPE -> IS_UNICODE > - convert_to_text -> convert_to_unicode > - convert_to_text_ex -> convert_to_unicode_ex Would the cleanup include the engine - i.e. all the UG-ly stuff in macros, functions, etc. - or only ext/* part? -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com --- ## #38140 — Scott MacVicar — 2008-06-10T13:05:43+00:00 URL: https://externals.io/message/38103#38140 · In reply to: #38138 I'm working on the patch to remove stuff from Zend/*, I've yet to change any of the macros. Will most likely leave that to last. Scott Stanislav Malyshev wrote: > > […] > > Would the cleanup include the engine - i.e. all the UG-ly stuff in > macros, functions, etc. - or only ext/* part? --- ## #38139 — Steph Fox — 2008-06-10T13:06:57+00:00 URL: https://externals.io/message/38103#38139 · In reply to: #38138 Hi Stas, > > […] > > Would the cleanup include the engine - i.e. all the UG-ly stuff in > macros, functions, etc. - or only ext/* part? Scott's working on the engine. We just cleaned up the rest. - Steph > -- > Stanislav Malyshev, Zend Software Architect > stas@zend.com http://www.zend.com/ > (408)253-8829 MSN: stas@zend.com --- ## #38152 — Andrei Zmievski — 2008-06-10T20:50:28+00:00 URL: https://externals.io/message/38103#38152 · In reply to: #38127 Yes, good idea. PRE-BFUC (PRE-BigFreakingUnicodeCleanup) -Andrei Stanislav Malyshev wrote: > Hi! > > > […] > > I think it would also be nice to tag it before the change, just in case. --- ## #43512 — Felipe Pena — 2009-03-27T11:37:08+00:00 URL: https://externals.io/message/38103#43512 · In reply to: #38152 Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no mail will be sent. + * ZendEngine2/zend.c + ZendEngine2/zend.h + ZendEngine2/zend_API.c + ZendEngine2/zend_API.h + ZendEngine2/zend_builtin_functions.c + ZendEngine2/zend_closures.c + ZendEngine2/zend_compile.c + ZendEngine2/zend_constants.c + ZendEngine2/zend_exceptions.c + ZendEngine2/zend_execute.c + ZendEngine2/zend_execute_API.c + ZendEngine2/zend_hash.c + ZendEngine2/zend_ini.c + ZendEngine2/zend_ini_parser.y + ZendEngine2/zend_language_parser.y + ZendEngine2/zend_language_scanner.c + ZendEngine2/zend_language_scanner.l + ZendEngine2/zend_language_scanner_defs.h + ZendEngine2/zend_object_handlers.c + ZendEngine2/zend_operators.c + ZendEngine2/zend_operators.h + ZendEngine2/zend_unicode.h + ZendEngine2/zend_variables.c + ZendEngine2/zend_vm_def.h + ZendEngine2/zend_vm_execute.h + ext/calendar/calendar.c + ext/com_dotnet/com_variant.c + ext/date/php_date.c + ext/dom/php_dom.c + ext/gettext/gettext.c + ext/iconv/iconv.c + ext/libxml/libxml.c + ext/libxml/php_libxml.h + ext/oci8/oci8.c + ext/oci8/oci8_collection.c + ext/oci8/oci8_interface.c + ext/oci8/oci8_lob.c + ext/oci8/oci8_statement.c + ext/pcre/php_pcre.c + ext/pcre/php_pcre.h + ext/pdo/pdo_dbh.c + ext/pdo/pdo_stmt.c + ext/reflection/php_reflection.c + ext/session/mod_files.c + ext/session/session.c + ext/simplexml/simplexml.c + ext/soap/php_encoding.c + ext/soap/php_http.c + ext/soap/php_packet_soap.c + ext/soap/soap.c + ext/spl/php_spl.c + ext/spl/spl_array.c + ext/spl/spl_directory.c + ext/spl/spl_dllist.c + ext/spl/spl_engine.h + ext/spl/spl_functions.c + ext/spl/spl_heap.c + ext/spl/spl_iterators.c + ext/spl/spl_observer.c + ext/sqlite/sqlite.c + ext/standard/array.c + ext/standard/basic_functions.c + ext/standard/dir.c + ext/standard/file.c + ext/standard/formatted_print.c + ext/standard/head.c + ext/standard/html.c + ext/standard/http_fopen_wrapper.c + ext/standard/incomplete_class.c + ext/standard/link.c + ext/standard/php_incomplete_class.h + ext/standard/proc_open.c + ext/standard/streamsfuncs.c + ext/standard/string.c + ext/standard/type.c + ext/standard/uniqid.c + ext/standard/var.c + ext/standard/var_unserializer.c + ext/standard/var_unserializer.re + ext/tidy/tidy.c + ext/tokenizer/tokenizer.c + ext/xml/xml.c + ext/xmlreader/php_xmlreader.c + main/SAPI.c + main/php_variables.c + main/rfc1867.c + main/spprintf.c + main/streams/streams.c: + - Removed: + - UG(unicode) checks + - pcre_cache_entry.unicode_mode + - Changed: + - ZEND_STR_TYPE -> IS_UNICODE + - convert_to_text -> convert_to_unicode + - convert_to_text_ex -> convert_to_unicode_ex + + (Felipe, Steph) Thanks. -- Regards, Felipe Pena --- ## #43513 — Hannes Magnusson — 2009-03-27T11:47:39+00:00 URL: https://externals.io/message/38103#43513 · In reply to: #43512 2009/3/27 Felipe Pena : > Hello, > just to inform, I've commited (yesterday) the patch removing the > UG(unicode) checks, etc across all source (except mysql exts). As the > patch has 492K, looks as no mail will be sent. [...] > +      (Felipe, Steph) Kudos!! -Hannes --- ## #43514 — David Coallier — 2009-03-27T11:50:20+00:00 URL: https://externals.io/message/38103#43514 · In reply to: #43513 2009/3/27 Hannes Magnusson : > 2009/3/27 Felipe Pena : > > […] > [...] Would you mind letting the list know when the commit has gone through? That way we can catch any possible bugs quicker? (I know we could simply do cvs up -dP repeatedly until we see changes but y'know ;-)) Thanks a million D --- ## #43515 — Scott MacVicar — 2009-03-27T11:56:29+00:00 URL: https://externals.io/message/38103#43515 · In reply to: #43514 David Coallier wrote: > 2009/3/27 Hannes Magnusson : > > […] > > Would you mind letting the list know when the commit has gone through? > That way we can catch any possible bugs quicker? (I know we could > simply do cvs up -dP repeatedly until we see changes but y'know ;-)) > It went through last night, its the first line of his email... Scott --- ## #43516 — Sebastian Bergmann — 2009-03-27T12:02:56+00:00 URL: https://externals.io/message/38103#43516 · In reply to: #43512 Felipe Pena schrieb: > + - Removed: > + - UG(unicode) checks > + - pcre_cache_entry.unicode_mode > + - Changed: > + - ZEND_STR_TYPE -> IS_UNICODE > + - convert_to_text -> convert_to_unicode > + - convert_to_text_ex -> convert_to_unicode_ex > + > + (Felipe, Steph) Yay you! -- Sebastian Bergmann Co-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ --- ## #43517 — David Coallier — 2009-03-27T12:05:10+00:00 URL: https://externals.io/message/38103#43517 · In reply to: #43516 2009/3/27 Sebastian Bergmann : > Felipe Pena schrieb: > > […] > >  Yay you! > Only thing I have to say about this is: "Dar dar" sorry about this :) -- Slan, David --- ## #43519 — Steph — 2009-03-27T15:08:15+00:00 URL: https://externals.io/message/38103#43519 · In reply to: #43512 Felipe Pena wrote: > Hello, > just to inform, I've commited (yesterday) the patch removing the > UG(unicode) checks, etc across all source (except mysql exts). As the > patch has 492K, looks as no mail will be sent. I'd given up hope of ever seeing that reach CVS :) Thanks Felipe! - Steph