# I suppose I should be happy ...

- Thread: https://externals.io/message/38009
- Original archive: https://news-web.php.net/php.internals/38009
- Started by Richard Quadling on 2008-05-30T09:56:40+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #38009 — Richard Quadling — 2008-05-30T09:56:40+00:00

URL: https://externals.io/message/38009#38009

Hi.

From the recent daily cvs changelog ...

+2008-05-29  Scott MacVicar  <scott@macvicar.net>
+
+    * (PHP_5_2)
+      NEWS
+      TSRM/tsrm_win32.c:
+      MFH: Fix a bug when command is quoted and parameters are quoted
during call
+      to exec, the result is that cmd.exe /c strips the first and last quote.
+
+    * (PHP_5_3)
+      TSRM/tsrm_win32.c:
+      MFH: Fix bug when command is quoted and parameters are quoted during call
+      to exec, the result is that cmd.exe /c strips the first and last quote.
+
+    * TSRM/tsrm_win32.c:
+      Fix bug when command is quoted and parameters are quoted during call to
+      exec, the result is that cmd.exe /c strips the first and last quote.
+

This really should have been tagged with all those bogus-fied bugs. A
patch was supplied in August 2007 and there were many discussions in
the bugs by many users.

http://bugs.php.net/bug.php?id=34671
http://bugs.php.net/bug.php?id=35961
http://bugs.php.net/bug.php?id=25361
(There may be others.)

Until now.

What changed?


Can someone please check out #15818, #43784 with the patch at #43261

Thanks.

-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"

---

## #38010 — Scott MacVicar — 2008-05-30T10:04:59+00:00

URL: https://externals.io/message/38009#38010 · In reply to: #38009

Hi Richard,

I never even looked for bug reports, I found this while trying to deal 
with an issue one of our customers reported. I then tracked through the 
code and read cmd.exe /?

After I read what it said it did for quotes, I created a fix and tested it.

I guess none of the Windows developers saw the bug report.

Scott

Richard Quadling wrote:
> Hi.
> 
> From the recent daily cvs changelog ...
> 
> +2008-05-29  Scott MacVicar  <scott@macvicar.net>
> +
> +    * (PHP_5_2)
> +      NEWS
> +      TSRM/tsrm_win32.c:
> +      MFH: Fix a bug when command is quoted and parameters are quoted
> during call
> +      to exec, the result is that cmd.exe /c strips the first and last quote.
> +
> +    * (PHP_5_3)
> +      TSRM/tsrm_win32.c:
> +      MFH: Fix bug when command is quoted and parameters are quoted during call
> +      to exec, the result is that cmd.exe /c strips the first and last quote.
> +
> +    * TSRM/tsrm_win32.c:
> +      Fix bug when command is quoted and parameters are quoted during call to
> +      exec, the result is that cmd.exe /c strips the first and last quote.
> +
> 
> This really should have been tagged with all those bogus-fied bugs. A
> patch was supplied in August 2007 and there were many discussions in
> the bugs by many users.
> 
> http://bugs.php.net/bug.php?id=34671
> http://bugs.php.net/bug.php?id=35961
> http://bugs.php.net/bug.php?id=25361
> (There may be others.)
> 
> Until now.
> 
> What changed?
> 
> 
> Can someone please check out #15818, #43784 with the patch at #43261
> 
> Thanks.