# Couple Windows build fixes - Thread: https://externals.io/message/37514 - Original archive: https://news-web.php.net/php.internals/37514 - Started by Matt Wilmas on 2008-05-07T15:28:19+00:00 - Messages: 8 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #37514 — Matt Wilmas — 2008-05-07T15:28:19+00:00 URL: https://externals.io/message/37514#37514 Hi, One patch for 5.3 and one for HEAD, where they're not synched with the other. 5.3's math changes the other day missed one change to the php_* function (snaps are failing). And HEAD's Win Makefile still contains references to flex.skl after the re2c change, which causes an error for me, though its snaps are building, so maybe I'm the only one? - Matt --- ## #37521 — Hannes Magnusson — 2008-05-07T20:16:21+00:00 URL: https://externals.io/message/37514#37521 · In reply to: #37514 Could someone explain to me why he doesn't have karma? -Hannes > Hi, > > One patch for 5.3 and one for HEAD, where they're not synched with the > other. 5.3's math changes the other day missed one change to the php_* > function (snaps are failing). And HEAD's Win Makefile still contains > references to flex.skl after the re2c change, which causes an error for me, > though its snaps are building, so maybe I'm the only one? > > > - Matt --- ## #37528 — Steph Fox — 2008-05-08T00:43:54+00:00 URL: https://externals.io/message/37514#37528 · In reply to: #37521 Hi Hannes, CVS HEAD wasn't updated yet with the Windows build system because I was waiting for re2c development to settle down first, given that there was no re2c binary available that PHP could be built with at all for several weeks. But I agree with you, Matt should've been given access to everything from Day One, we all know he's brilliant :) - Steph ----- Original Message ----- From: "Hannes Magnusson" To: "Matt Wilmas" Cc: Sent: Wednesday, May 07, 2008 9:16 PM Subject: Re: [PHP-DEV] Couple Windows build fixes > Could someone explain to me why he doesn't have karma? > > -Hannes > > On Wed, May 7, 2008 at 5:28 PM, Matt Wilmas > wrote: > > […] --- ## #37530 — Rasmus Lerdorf — 2008-05-08T00:46:16+00:00 URL: https://externals.io/message/37514#37530 · In reply to: #37528 He never asked. Steph Fox wrote: > Hi Hannes, > > CVS HEAD wasn't updated yet with the Windows build system because I was > waiting for re2c development to settle down first, given that there was > no re2c binary available that PHP could be built with at all for several > weeks. > > But I agree with you, Matt should've been given access to everything > from Day One, we all know he's brilliant :) > > - Steph > > ----- Original Message ----- From: "Hannes Magnusson" > > To: "Matt Wilmas" > Cc: > Sent: Wednesday, May 07, 2008 9:16 PM > Subject: Re: [PHP-DEV] Couple Windows build fixes > > > > […] --- ## #37531 — Steph Fox — 2008-05-08T00:54:05+00:00 URL: https://externals.io/message/37514#37531 · In reply to: #37530 Then we'd better ask for him. Matt's been pushing patches all across the PHP source (if mostly at the Zend Engine) for ages. He comes and goes, but pretty much all of his patches were subsequently accepted. I don't recall off-hand which bits of the source he was given karma for a few weeks ago, but it's downright weird that it was ever limited. > He never asked. > > Steph Fox wrote: > > […] --- ## #37538 — Matt Wilmas — 2008-05-08T09:35:42+00:00 URL: https://externals.io/message/37514#37538 · In reply to: #37531 Hi all, Thanks guys and gals! (Steph, you're funny. ;o)) Yeah, I didn't get any karma after my account was approved a few weeks ago, though I told Marcus I'd been making random changes "all across the PHP source," so would need access to php-src and ZendEngine2... But I didn't expect that to just be given right away, so I didn't want to bug anyone (more) about it. Luckily my first two simple commits worked without wiping out the entire history of PHP or anything. :-O BTW, if I had karma for Zend stuff, I guess I could fix Bugs #44681 and #44830, assuming my proposed fixes are acceptable (should I have marked them Verified?). And speaking of bugs, I wasn't sure if I should close #44767 as Bogus, for example. Maybe I will in a few days unless I'm told not to. :-) Thanks again, Matt ----- Original Message ----- From: "Steph Fox" Sent: Wednesday, May 07, 2008 > Then we'd better ask for him. > > Matt's been pushing patches all across the PHP source (if mostly at the Zend > Engine) for ages. He comes and goes, but pretty much all of his patches were > subsequently accepted. I don't recall off-hand which bits of the source he > was given karma for a few weeks ago, but it's downright weird that it was > ever limited. > > > > […] several > > […] from > > […] the > > […] contains > > […] --- ## #37543 — Rasmus Lerdorf — 2008-05-08T16:15:47+00:00 URL: https://externals.io/message/37514#37543 · In reply to: #37538 Matt Wilmas wrote: > BTW, if I had karma for Zend stuff, I guess > I could fix Bugs #44681 and #44830 You already have Zend karma. --- ## #37544 — Matt Wilmas — 2008-05-08T16:28:28+00:00 URL: https://externals.io/message/37514#37544 · In reply to: #37543 Hi Rasmus, ----- Original Message ----- From: "Rasmus Lerdorf" Sent: Thursday, May 08, 2008 > Matt Wilmas wrote: > > […] > > You already have Zend karma. I was going by your CVSROOT/avail commit, and checking the file now, it seems I only have access to Zend[Engine2]/tests. I could try commiting something (don't know if there's another way for me to "check"), but I didn't expect that it would work. Maybe you just changed the wrong section...? :-) Ahh, just before I sent this, I see you changed it. Cool, thanks. Thanks, Matt