# CVS Account Request

- Thread: https://externals.io/message/36999
- Original archive: https://news-web.php.net/php.internals/36999
- Started by Tatsuo Ishii on 2008-04-14T11:21:47+00:00
- Messages: 6
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #36999 — Tatsuo Ishii — 2008-04-14T11:21:47+00:00

URL: https://externals.io/message/36999#36999

Hi,

I would like to contribute to ext/pgsql module. Could I have CVS
account?

I've been working on PostgreSQL development for years. My intention
is to catch up PostgreSQL develpment especially when new API is
added. For example an API added to PostgreSQL 8.1 (back to 2005) is
not in PHP yet.

I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
and he seems to be happy.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

---

## #37017 — Marcus Boerger — 2008-04-15T10:39:34+00:00

URL: https://externals.io/message/36999#37017 · In reply to: #36999

Hello Tatsuo,

  first of all thanks for offering to help!

  the usual way is to provide a few patches. You can check
  http://bugs.php.net for open bugs in your area. When we like the patches
  we'll apply them and give you an account.

marcus

Monday, April 14, 2008, 1:21:47 PM, you wrote:

> Hi,

> I would like to contribute to ext/pgsql module. Could I have CVS
> account?

> I've been working on PostgreSQL development for years. My intention
> is to catch up PostgreSQL develpment especially when new API is
> added. For example an API added to PostgreSQL 8.1 (back to 2005) is
> not in PHP yet.

> I have talked to Yasuo Ohgaki (one of the pgsql module maintainers)
> and he seems to be happy.
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan




Best regards,
 Marcus

---

## #37024 — Tatsuo Ishii — 2008-04-15T12:51:10+00:00

URL: https://externals.io/message/36999#37024 · In reply to: #37017

Hello Marcus,

Thanks for guiding me. I'm going to make patches in a few days.
BTW, the problem I'm talking about does not seem to exist in the bug
database.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

> Hello Tatsuo,
> 
>   first of all thanks for offering to help!
> 
>   the usual way is to provide a few patches. You can check
>   http://bugs.php.net for open bugs in your area. When we like the patches
>   we'll apply them and give you an account.
> 
> marcus
> 
> Monday, April 14, 2008, 1:21:47 PM, you wrote:
> 
> > […]
> 
> > […]
> 
> > […]
> 
> > […]
> 
> 
> 
> 
> Best regards,
>  Marcus

---

## #37025 — johannes@php.net — 2008-04-15T13:41:04+00:00

URL: https://externals.io/message/36999#37025 · In reply to: #37024

> 
> Thanks for guiding me. I'm going to make patches in a few days.
> BTW, the problem I'm talking about does not seem to exist in the bug
> database.

Then open a new ticket - that's what the bug tracker is for. :-)

johannes

---

## #37070 — Tatsuo Ishii — 2008-04-17T14:50:13+00:00

URL: https://externals.io/message/36999#37070 · In reply to: #37024

Here are the patches against 5.2 HEAD.

Modified API's are:

1) pg_lo_create now accepts an optional parameter (large object
   id). This corresponds to lo_create() which is new in PostgreSQL 8.1.

2) new API: pg_lo_import_with_oid. Same as pg_lo_import except that it
   accepts large object id. This corresponds to lo_import_with_oid()
   which is new in PostgreSQL 8.4 (current).
--
Tatsuo Ishii
SRA OSS, Inc. Japan

> Hello Marcus,
> 
> Thanks for guiding me. I'm going to make patches in a few days.
> BTW, the problem I'm talking about does not seem to exist in the bug
> database.
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> 
> > […]

---

## #37195 — Antony Dovgal — 2008-04-23T07:43:37+00:00

URL: https://externals.io/message/36999#37195 · In reply to: #37070

> Here are the patches against 5.2 HEAD.

First of all, please use `diff -u`, not just `diff` - unified diffs are much more readable.
 
> Modified API's are:
> 
> 1) pg_lo_create now accepts an optional parameter (large object
>    id). This corresponds to lo_create() which is new in PostgreSQL 8.1.
> 
> 2) new API: pg_lo_import_with_oid. Same as pg_lo_import except that it
>    accepts large object id. This corresponds to lo_import_with_oid()
>    which is new in PostgreSQL 8.4 (current).

Is there a real need for a new function?
Can't we modify pg_lo_import() to accept one more argument?

-- 
Wbr, 
Antony Dovgal