# [bug in php5.3 cvs] op2 of OP_DATA which after INIT_NS_FCALL_BY_NAME is uninitialized

- Thread: https://externals.io/message/34265
- Original archive: https://news-web.php.net/php.internals/34265
- Started by phpxcache on 2007-12-28T09:12:22+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #34265 — phpxcache — 2007-12-28T09:12:22+00:00

URL: https://externals.io/message/34265#34265

http://bugs.php.net/bug.php?id=43696
Description:
------------
as you can see in zend_compile.c
        opline->opcode = ZEND_INIT_NS_FCALL_BY_NAME;
ZEND_INIT_NS_FCALL_BY_NAME's op1 is initialized, so is op2
.........
        opline->opcode = ZEND_OP_DATA;
ZEND_OP_DATA's op1 is initialized here but op2 is not

it may not cause problem in zend executor but may in opcode
optimizers/cachers

suggested fix:
Index: zend_compile.c
===================================================================
RCS file: /repository/ZendEngine2/zend_compile.c,v
retrieving revision 1.647.2.27.2.41.2.32
diff -u -r1.647.2.27.2.41.2.32 zend_compile.c
--- zend_compile.c  27 Dec 2007 13:52:05 -0000  1.647.2.27.2.41.2.32
+++ zend_compile.c  28 Dec 2007 08:56:41 -0000
@@ -1504,6 +1504,7 @@
        Z_TYPE(opline->op1.u.constant) = IS_STRING;
        Z_STRLEN(opline->op1.u.constant) =
Z_STRLEN(function_name->u.constant) - prefix_len;
        Z_STRVAL(opline->op1.u.constant) =
zend_str_tolower_dup(Z_STRVAL(function_name->u.constant) + prefix_len,
Z_STRLEN(opline->op1.u.constant));
+       SET_UNUSED(opline->op2);
        opline->extended_value =
zend_hash_func(Z_STRVAL(opline->op1.u.constant),
Z_STRLEN(opline->op1.u.constant) + 1);
    } else {
        opline->opcode = ZEND_INIT_FCALL_BY_NAME;

---

## #34266 — Dmitry Stogov — 2007-12-28T09:47:37+00:00

URL: https://externals.io/message/34265#34266 · In reply to: #34265

Thanks for catching this.
Committed.

Dmitry.

phpxcache wrote:
> http://bugs.php.net/bug.php?id=43696
> Description:
> ------------
> as you can see in zend_compile.c
>         opline->opcode = ZEND_INIT_NS_FCALL_BY_NAME;
> ZEND_INIT_NS_FCALL_BY_NAME's op1 is initialized, so is op2
> .........
>         opline->opcode = ZEND_OP_DATA;
> ZEND_OP_DATA's op1 is initialized here but op2 is not
> 
> it may not cause problem in zend executor but may in opcode
> optimizers/cachers
> 
> suggested fix:
> Index: zend_compile.c
> ===================================================================
> RCS file: /repository/ZendEngine2/zend_compile.c,v
> retrieving revision 1.647.2.27.2.41.2.32
> diff -u -r1.647.2.27.2.41.2.32 zend_compile.c
> --- zend_compile.c  27 Dec 2007 13:52:05 -0000  1.647.2.27.2.41.2.32
> +++ zend_compile.c  28 Dec 2007 08:56:41 -0000
> @@ -1504,6 +1504,7 @@
>         Z_TYPE(opline->op1.u.constant) = IS_STRING;
>         Z_STRLEN(opline->op1.u.constant) =
> Z_STRLEN(function_name->u.constant) - prefix_len;
>         Z_STRVAL(opline->op1.u.constant) =
> zend_str_tolower_dup(Z_STRVAL(function_name->u.constant) + prefix_len,
> Z_STRLEN(opline->op1.u.constant));
> +       SET_UNUSED(opline->op2);
>         opline->extended_value =
> zend_hash_func(Z_STRVAL(opline->op1.u.constant),
> Z_STRLEN(opline->op1.u.constant) + 1);
>     } else {
>         opline->opcode = ZEND_INIT_FCALL_BY_NAME;