# PHP6 - rar extension

- Thread: https://externals.io/message/31973
- Original archive: https://news-web.php.net/php.internals/31973
- Started by BuildSmart on 2007-08-30T03:15:26+00:00
- Messages: 7
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #31973 — BuildSmart — 2007-08-30T03:15:26+00:00

URL: https://externals.io/message/31973#31973

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've fixed the rar extension, was a no-brainer, a one-line change,  
not worthy of a patch file.

@ -628,7 +628,7 @
  /* {{{ rar_functions[]
   *
   */
- -function_entry rar_functions[] = {
+zend_function_entry rar_functions[] = {
  	PHP_FE(rar_open,	NULL)
  	PHP_FE(rar_list,	NULL)
  	PHP_FE(rar_entry_get,	NULL)

- -- BuildSmart

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1jZO0hzWbkf0eKgRAntaAJ0USGFs8mWpDZViykUZiwIx/mVyOgCfeEYc
toF9N9VjiK0uQRVio9S0dKM=
=4Orv
-----END PGP SIGNATURE

---

## #31974 — BuildSmart — 2007-08-30T04:02:50+00:00

URL: https://externals.io/message/31973#31974 · In reply to: #31973

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1




> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I've fixed the rar extension, was a no-brainer, a one-line change,  
> not worthy of a patch file.
>
> @ -628,7 +628,7 @
>  /* {{{ rar_functions[]
>   *
>   */
> - -function_entry rar_functions[] = {
> +zend_function_entry rar_functions[] = {
>  	PHP_FE(rar_open,	NULL)
>  	PHP_FE(rar_list,	NULL)
>  	PHP_FE(rar_entry_get,	NULL)
>
> - -- BuildSmart

Spoke too soon, while it builds with wanring it doesn't function  
properly and segfaults so I need to look at it a little closer.

- -- BuildSmart


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1kFr0hzWbkf0eKgRAkrXAKDchoZeVNjEzuMUHBkK8OcAPYv3CACfdYEA
8NCMojpzaaciknqteEjDLBA=
=6mHL
-----END PGP SIGNATURE

---

## #31976 — Pierre — 2007-08-30T05:32:44+00:00

URL: https://externals.io/message/31973#31976 · In reply to: #31974

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> 
>
> > […]
>
> Spoke too soon, while it builds with wanring it doesn't function
> properly and segfaults so I need to look at it a little closer.

Tony reads this list however I would suggest to use the right place to
post patch or report bugs:

http://pecl.php.net/package/rar to report a bug for the rar package.
http://pecl.php.net/support.php for the pecl-dev mailing list

Using the issues tracker will ensure that your patch will not get lost.

Cheers,
--Pierre

---

## #31980 — Antony Dovgal — 2007-08-30T09:35:08+00:00

URL: https://externals.io/message/31973#31980 · In reply to: #31976

What was the problem again?


> 
> > […]
> 
> Tony reads this list however I would suggest to use the right place to
> post patch or report bugs:
> 
> http://pecl.php.net/package/rar to report a bug for the rar package.
> http://pecl.php.net/support.php for the pecl-dev mailing list
> 
> Using the issues tracker will ensure that your patch will not get lost.
> 
> Cheers,
> --Pierre
> 


-- 
Wbr, 
Antony Dovgal

---

## #31981 — Antony Dovgal — 2007-08-30T10:23:23+00:00

URL: https://externals.io/message/31973#31981

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> /php-src/ext/rar/rar.cpp: In function 'int zm_startup_rar(int, int)':
> /php-src/ext/rar/rar.cpp:677: error: invalid conversion from 'void*'  
> to 'UChar*'
> 
> ext/rar/rar.cpp:
> 673:PHP_MINIT_FUNCTION(rar)
> 674:{
> 675:	zend_class_entry rar_class_entry;
> 676:
> 677:	INIT_CLASS_ENTRY(rar_class_entry, "RarEntry", rar_functions);
> 678:	rar_class_entry_ptr = zend_register_internal_class 
> (&rar_class_entry TSRMLS_CC);

And you fixed it by changing "function_entry" to "zend_function_entry"?
Well, then your compiler went mad. 

Because they are absolutely equal:
main/php, line 177
#define function_entry          zend_function_entry

-- 
Wbr, 
Antony Dovgal

---

## #31982 — Antony Dovgal — 2007-08-30T10:40:21+00:00

URL: https://externals.io/message/31973#31982 · In reply to: #31981

`cvs up` both HEAD and PECL/rar, I fixed the build.

There were two separate problems:
http://news.php.net/php.zend-engine.cvs/5979
http://news.php.net/php.pecl.cvs/8490


> 
> > […]
> 
> And you fixed it by changing "function_entry" to "zend_function_entry"?
> Well, then your compiler went mad. 
> 
> Because they are absolutely equal:
> main/php, line 177
> #define function_entry          zend_function_entry
> 


-- 
Wbr, 
Antony Dovgal

---

## #31987 — BuildSmart — 2007-08-30T19:04:23+00:00

URL: https://externals.io/message/31973#31987 · In reply to: #31981

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yeah, I had just built something else using gcc 2.95 and forgot to  
switch back to 4.0, it sailed through giving it a warning and not an  
error.



> 
> > […]
>
> And you fixed it by changing "function_entry" to  
> "zend_function_entry"?
> Well, then your compiler went mad.
>
> Because they are absolutely equal:
> main/php, line 177
> #define function_entry          zend_function_entry
>
> -- 
> Wbr,
> Antony Dovgal
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFG1xS30hzWbkf0eKgRAhqjAJwJg6mwjOIbutddcDTbOt4RNi3chgCgv+Zy
rHjYQJRyxvq5/+RAdgOx9eE=
=PuSg
-----END PGP SIGNATURE