# [PATCH] Net_URL

- Thread: https://externals.io/message/25809
- Original archive: https://news-web.php.net/php.internals/25809
- Started by Alexei on 2006-09-24T21:11:46+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #25809 — Alexei — 2006-09-24T21:11:46+00:00

URL: https://externals.io/message/25809#25809

Here is a patch for

// $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $
//
// Net_URL Class

Misspelled variable in function Net_URL::setProtocol()


418c418
<         $this->port     = is_null($port) ? 
$this->getStandardPort($protocal) : $port;
---
 >         $this->port     = is_null($port) ? 
$this->getStandardPort($protocol) : $port;

---

## #25811 — Johannes Schlueter — 2006-09-24T21:28:22+00:00

URL: https://externals.io/message/25809#25811 · In reply to: #25809

Please send this to an PEAR list or report a bug at pear.php.net, 
internals is the wrong place for this.

And as a related note: diff -u is way better readable and preferred.

johannes

Alexei wrote:
> Here is a patch for
>
> // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $
> //
> // Net_URL Class
>
> Misspelled variable in function Net_URL::setProtocol()
>
>
> 418c418
> <         $this->port     = is_null($port) ? 
> $this->getStandardPort($protocal) : $port;
> ---
> > […]
> $this->getStandardPort($protocol) : $port;

---

## #25810 — Jan Lehnardt — 2006-09-24T21:28:38+00:00

URL: https://externals.io/message/25809#25810 · In reply to: #25809

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Alexei,
Thanks you for your patch! I committed it.

For future reference however, these patches should go into
the bug system[1] and there is a dedicated PEAR development
related list[2].

Best,
Jan
- --
[1] http://pear.php.net/bugs/search.php?cmd=display&package_name%5B% 
5D=Net_URL
[2] pear-dev@lists.php.net



> Here is a patch for
>
> // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $
> //
> // Net_URL Class
>
> Misspelled variable in function Net_URL::setProtocol()
>
>
> 418c418
> <         $this->port     = is_null($port) ? $this->getStandardPort 
> ($protocal) : $port;
> ---
> > […]
> ($protocol) : $port;
>
> -- 
> 
> 
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (Darwin)

iD8DBQFFFviH7KW8t7uWVrARAh0xAJ9rAm/qs/K+lYcN7GFnzgt6ksCz2wCgxRcY
uqZaLNQ9ZFt1vhu2lPiuxzU=
=Df9R
-----END PGP SIGNATURE

---

## #25812 — Alexei — 2006-09-24T21:44:47+00:00

URL: https://externals.io/message/25809#25812 · In reply to: #25810

Thanks Jan

Sorry guys, description of how to submit patches was a bit confusing on
pear website.

Alexei



Jan Lehnardt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hey Alexei,
> Thanks you for your patch! I committed it.
> 
> For future reference however, these patches should go into
> the bug system[1] and there is a dedicated PEAR development
> related list[2].
> 
> Best,
> Jan
> - --
> [1] 
> http://pear.php.net/bugs/search.php?cmd=display&package_name%5B%5D=Net_URL
> [2] pear-dev@lists.php.net
> 
> 
> 
> > […]
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (Darwin)
> 
> iD8DBQFFFviH7KW8t7uWVrARAh0xAJ9rAm/qs/K+lYcN7GFnzgt6ksCz2wCgxRcY
> uqZaLNQ9ZFt1vhu2lPiuxzU=
> =Df9R
> -----END PGP SIGNATURE