# PHP6 broken

- Thread: https://externals.io/message/24041
- Original archive: https://news-web.php.net/php.internals/24041
- Started by Dmitry Stogov on 2006-06-09T14:45:47+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #24041 — Dmitry Stogov — 2006-06-09T14:45:47+00:00

URL: https://externals.io/message/24041#24041

Hi Marcus,

Could you please fix PHP6 build.
You broke it day or two ago :(

After your modifications of ext/reflection PHP always emits error messages
about method incompatibilities.

I am not sure if static methods must be checked for compatibility (I mean
ReflectionMethod::export()), but ReflectionMethod::invoke() is not static.

Thanks. Dmitry.

---

## #24043 — Hannes Magnusson — 2006-06-09T15:06:02+00:00

URL: https://externals.io/message/24041#24043 · In reply to: #24041

> Hi Marcus,
>
> Could you please fix PHP6 build.
> You broke it day or two ago :(
Yeah, sorry about that, was my fault (it broke 5_2 to).

Actually, this bug has been there for a while, but the engine didn't
catch it since it had no idea which parameters the methods had.

I have a patch ready, which moves all methods from ReflectionFunction
into ReflectionFunctionAbstract (except from export, invoke &
invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just
need someone to review it before I commit it.

-Hannes

>
> After your modifications of ext/reflection PHP always emits error messages
> about method incompatibilities.
>
> I am not sure if static methods must be checked for compatibility (I mean
> ReflectionMethod::export()), but ReflectionMethod::invoke() is not static.
>
> Thanks. Dmitry.

---

## #24069 — Marcus Boerger — 2006-06-10T00:16:33+00:00

URL: https://externals.io/message/24041#24069 · In reply to: #24043

Hello Hannes,

  the patch looks good and solves the issues as far as i can tell. We
might want to make the abstract part an interface but we'll see. Just
commit for now.

best regards
marcus

Friday, June 9, 2006, 5:06:02 PM, you wrote:

> 
> > […]
> Yeah, sorry about that, was my fault (it broke 5_2 to).

> Actually, this bug has been there for a while, but the engine didn't
> catch it since it had no idea which parameters the methods had.

> I have a patch ready, which moves all methods from ReflectionFunction
> into ReflectionFunctionAbstract (except from export, invoke &
> invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just
> need someone to review it before I commit it.

> -Hannes

> > […]




Best regards,
 Marcus