# curl_multi_info_read patch review

- Thread: https://externals.io/message/23084
- Original archive: https://news-web.php.net/php.internals/23084
- Started by Brian J. France on 2006-05-02T18:48:14+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #23084 — Brian J. France — 2006-05-02T18:48:14+00:00

URL: https://externals.io/message/23084#23084

Some guys at work created this patch and have been running with it  
for a while now.

Could I get a few more eyeballs on this?

http://www.brianfrance.com/software/php/curl_multi_read.patch

Quote from our internal bug:

   "The attached patch implements `curl_multi_info_read()`, as well as  
fixing some memory leak issues and reference problems in the original  
source."

Should I keep it internal or commit it?

Thanks,

Brian

---

## #23090 — Sterling Hughes — 2006-05-02T20:56:01+00:00

URL: https://externals.io/message/23084#23090 · In reply to: #23084

please commit it, looks good.

thanks,
sterling


> Some guys at work created this patch and have been running with it
> for a while now.
>
> Could I get a few more eyeballs on this?
>
> http://www.brianfrance.com/software/php/curl_multi_read.patch
>
> Quote from our internal bug:
>
>    "The attached patch implements `curl_multi_info_read()`, as well as
> fixing some memory leak issues and reference problems in the original
> source."
>
> Should I keep it internal or commit it?
>
> Thanks,
>
> Brian

---

## #23092 — Brian J. France — 2006-05-02T21:29:43+00:00

URL: https://externals.io/message/23084#23092 · In reply to: #23090

PHP_5_1 and head or just head?

It could be considered bug fix since curl_multi_info_read was there,  
but not implemented.

Brian



> please commit it, looks good.
>
> thanks,
> sterling
>
> 
> > […]

---

## #23093 — Sterling Hughes — 2006-05-02T21:36:25+00:00

URL: https://externals.io/message/23084#23093 · In reply to: #23092

not having tested it, i don't know.  this is certainly a RM question,
but if it doesn't break the compile, it does not look like it has the
potential to damage previously existing infrastructure.

-sterling


> PHP_5_1 and head or just head?
>
> It could be considered bug fix since curl_multi_info_read was there,
> but not implemented.
>
> Brian
>
>
> 
> > […]

---

## #23095 — Ilia Alshanetsky — 2006-05-02T22:15:28+00:00

URL: https://externals.io/message/23084#23095 · In reply to: #23092

Apply this to HEAD for now, and once I'll review I'll give a you a go  
ahead for PHP_5_2 branch that will be created. For now we'll just add  
it to our 5.2 wiki TODO list.




> PHP_5_1 and head or just head?
>
> It could be considered bug fix since curl_multi_info_read was  
> there, but not implemented.

Ilia Alshanetsky
Advanced Internet Designs Inc.
ilia@prohost.org

P.S. Sterling, you're alive!