# Joshua's upload progress patch

- Thread: https://externals.io/message/23032
- Original archive: https://news-web.php.net/php.internals/23032
- Started by Rasmus Lerdorf on 2006-04-29T14:28:01+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #23032 — Rasmus Lerdorf — 2006-04-29T14:28:01+00:00

URL: https://externals.io/message/23032#23032

I had another look at Joshua's upload progress patch:

http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/php-patch/patch.upload-progress-callback-v4.1-for-php5.0.3.txt

I seem to remember there being some valid reason for not adding this 
patch, but looking over the code, it doesn't jump out at me.  It seems 
safe enough unless I am missing a subtle TSRM issue.  Anybody remember 
what the problem was?

-Rasmus

---

## #23033 — Rasmus Lerdorf — 2006-04-29T14:54:05+00:00

URL: https://externals.io/message/23032#23033 · In reply to: #23032

Rasmus Lerdorf wrote:
> I had another look at Joshua's upload progress patch:
> 
> http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/php-patch/patch.upload-progress-callback-v4.1-for-php5.0.3.txt 
> 
> 
> I seem to remember there being some valid reason for not adding this 
> patch, but looking over the code, it doesn't jump out at me.  It seems 
> safe enough unless I am missing a subtle TSRM issue.  Anybody remember 
> what the problem was?

There is variation here:

   http://www.zend.com/zend/week/pat/pat23.txt

Quite similar.  The one change I would make to both would be to put the 
temp filename in the callback call so the extension on the other end has 
a chance to keep track of which upload caused the callback to trigger in 
a threaded environment with concurrent uploads.

-Rasmus

---

## #24158 — Markus Fischer — 2006-06-20T09:03:01+00:00

URL: https://externals.io/message/23032#24158 · In reply to: #23033

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Rasmus,

do you think you can take another look at the patch and the extension so
maybe it can be included into PHP?

thanks,
- - Markus

Rasmus Lerdorf wrote:
> Rasmus Lerdorf wrote:
> > […]
> 
> There is variation here:
> 
>   http://www.zend.com/zend/week/pat/pat23.txt
> 
> Quite similar.  The one change I would make to both would be to put the
> temp filename in the callback call so the extension on the other end has
> a chance to keep track of which upload caused the callback to trigger in
> a threaded environment with concurrent uploads.
> 
> -Rasmus
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEl7nF1nS0RcInK9ARAuF+AJ939ygS2BM9htXzOnlhR4frP0pHiwCdHkS+
K+aeMpVnsoNxtzfC1ZhCvzI=
=zcmu
-----END PGP SIGNATURE