# PHP 5.1.3RC2 Released - Thread: https://externals.io/message/22620 - Original archive: https://news-web.php.net/php.internals/22620 - Started by Ilia Alshanetsky on 2006-03-30T19:37:44+00:00 - Messages: 6 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #22620 — Ilia Alshanetsky — 2006-03-30T19:37:44+00:00 URL: https://externals.io/message/22620#22620 PHP 5.1.3RC2 has just been released, about a week late, but better late then never ;-). Please test this RC as much as possible, if it proves to be stable, this release will be published as final next week Thursday. The source packages can be found here: http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz MD5: 1e66780413580bc4a0742fa302735c99 Win32 binaries will be available for download shortly. Ilia 5.1 Release Master --- ## #22621 — Edin Kadribasic — 2006-03-31T06:08:37+00:00 URL: https://externals.io/message/22620#22621 · In reply to: #22620 The windows build can be downloaded from: http://downloads.php.net/edink/php-5.1.3RC2-Win32.zip MD5 (php-5.1.3RC2-Win32.zip) = 5979f3c2960eca5f46d1cc2c967e4332 http://downloads.php.net/edink/pecl-5.1.3RC2-Win32.zip MD5 (pecl-5.1.3RC2-Win32.zip) = 29d0a29b3a533dee8527e6abc9627a29 Edin Ilia Alshanetsky wrote: > PHP 5.1.3RC2 has just been released, about a week late, but better late > then never ;-). Please test this RC as much as possible, if it proves to > be stable, this release will be published as final next week Thursday. > > The source packages can be found here: > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 > MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz > MD5: 1e66780413580bc4a0742fa302735c99 > > Win32 binaries will be available for download shortly. > > Ilia > 5.1 Release Master --- ## #22640 — Ron Korving — 2006-04-01T20:18:09+00:00 URL: https://externals.io/message/22620#22640 · In reply to: #22620 Nice to see RC2 :) I noticed that few of my earlier observations have not been addressed though, and these are minor cleanups, but they are cleanups: 1) An unused variable 'i' in insertionsort() in main/mergesort.c 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: image/gif" with 2 spaces between "Content-Type" and "image/gif" 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there are 2 `fprintf()` calls which could just as easily be done with 1: fprintf(stderr, "%s\n", message); instead of: fprintf(stderr, "%s", message); fprintf(stderr, "\n"); I can't 100% guarantee that this is all safe, but it all seems(!) perfectly safe to me. Regards, Ron "Ilia Alshanetsky" wrote in message news:442C3388.3000603@prohost.org... > PHP 5.1.3RC2 has just been released, about a week late, but better late > then never ;-). Please test this RC as much as possible, if it proves to > be stable, this release will be published as final next week Thursday. > > The source packages can be found here: > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 > MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz > MD5: 1e66780413580bc4a0742fa302735c99 > > Win32 binaries will be available for download shortly. > > Ilia > 5.1 Release Master --- ## #22641 — Ron Korving — 2006-04-01T20:18:09+00:00 URL: https://externals.io/message/22620#22641 · In reply to: #22620 Nice to see RC2 :) I noticed that few of my earlier observations have not been addressed though, and these are minor cleanups, but they are cleanups: 1) An unused variable 'i' in insertionsort() in main/mergesort.c 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: image/gif" with 2 spaces between "Content-Type" and "image/gif" 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there are 2 `fprintf()` calls which could just as easily be done with 1: fprintf(stderr, "%s\n", message); instead of: fprintf(stderr, "%s", message); fprintf(stderr, "\n"); I can't 100% guarantee that this is all safe, but it all seems(!) perfectly safe to me. Regards, Ron "Ilia Alshanetsky" wrote in message news:442C3388.3000603@prohost.org... > PHP 5.1.3RC2 has just been released, about a week late, but better late > then never ;-). Please test this RC as much as possible, if it proves to > be stable, this release will be published as final next week Thursday. > > The source packages can be found here: > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 > MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz > MD5: 1e66780413580bc4a0742fa302735c99 > > Win32 binaries will be available for download shortly. > > Ilia > 5.1 Release Master --- ## #22642 — Marcus Boerger — 2006-04-01T22:07:44+00:00 URL: https://externals.io/message/22620#22642 · In reply to: #22641 Hello Ron, if only these two spots were all problems we had. :-) marcus Saturday, April 1, 2006, 10:18:09 PM, you wrote: > Nice to see RC2 :) > I noticed that few of my earlier observations have not been addressed > though, and these are minor cleanups, but they are cleanups: > 1) An unused variable 'i' in insertionsort() in main/mergesort.c > 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: > image/gif" with 2 spaces between "Content-Type" and "image/gif" > 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there > are 2 `fprintf()` calls which could just as easily be done with 1: > fprintf(stderr, "%s\n", message); > instead of: > fprintf(stderr, "%s", message); > fprintf(stderr, "\n"); > I can't 100% guarantee that this is all safe, but it all seems(!) perfectly > safe to me. > Regards, > Ron > "Ilia Alshanetsky" wrote in message > news:442C3388.3000603@prohost.org... > > […] Best regards, Marcus --- ## #22646 — Ilia Alshanetsky — 2006-04-02T17:59:52+00:00 URL: https://externals.io/message/22620#22646 · In reply to: #22640 The i variable inside insertionsort() is used by the swap() macro and is actually needed. The other two issues are indeed valid and patches to fix them have just been applied to CVS, thanks for pointing them out. Ilia Ron Korving wrote: > Nice to see RC2 :) > I noticed that few of my earlier observations have not been addressed > though, and these are minor cleanups, but they are cleanups: > > 1) An unused variable 'i' in insertionsort() in main/mergesort.c > 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: > image/gif" with 2 spaces between "Content-Type" and "image/gif" > 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there > are 2 `fprintf()` calls which could just as easily be done with 1: > fprintf(stderr, "%s\n", message); > instead of: > fprintf(stderr, "%s", message); > fprintf(stderr, "\n"); > > I can't 100% guarantee that this is all safe, but it all seems(!) perfectly > safe to me. > > Regards, > > Ron > > > "Ilia Alshanetsky" wrote in message > news:442C3388.3000603@prohost.org... > > […]