# Build breakage

- Thread: https://externals.io/message/19418
- Original archive: https://news-web.php.net/php.internals/19418
- Started by Edin Kadribasic on 2005-10-05T10:45:54+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #19418 — Edin Kadribasic — 2005-10-05T10:45:54+00:00

URL: https://externals.io/message/19418#19418

Hi Jani,

Your commit r 1.16 to ext/date/lib/timelib_structs.h broke the build on
Windows platform.

-#include "timelib_config.h"
+#include <timelib_config.h>

Why was this change neccessary and if it's not really, would you please
revert it?

Edin

---

## #19441 — Edin Kadribasic — 2005-10-06T12:35:27+00:00

URL: https://externals.io/message/19418#19441 · In reply to: #19418

Edin Kadribasic wrote:
> Hi Jani,
> 
> Your commit r 1.16 to ext/date/lib/timelib_structs.h broke the build on
> Windows platform.
> 
> -#include "timelib_config.h"
> +#include <timelib_config.h>
> 
> Why was this change neccessary and if it's not really, would you please
> revert it?

After strugling to get an anwer for this one it appears that the problem
is that Derick wants to maintain timelib as an independet 3rd party lib
that is also part of PHP core which means that in order for PHP to build
we need to add "timelib" to the global CFLAGS (or at least to the flags
of any extension what wants to use it). A mere include
"ext/date/php_date.h" wouldn't cut it.

Does anyone find this less than optimal?

Edin