# Improvement to test script 'bug22414'

- Thread: https://externals.io/message/17624
- Original archive: https://news-web.php.net/php.internals/17624
- Started by Rob Vaughn on 2005-08-08T19:07:24+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #17624 — Rob Vaughn — 2005-08-08T19:07:24+00:00

URL: https://externals.io/message/17624#17624

Attached is a universal 'diff' that adds a `crc32()` check to the 'passthru'
test as well as an `md5()` test.  This will help detect if there's a problem
with `md5()` or `crc32()` unless both are failing, which indicates a problem with
the 'mhash' functionality.

Cheers, Rob

---

## #17626 — Marcus Boerger — 2005-08-08T20:17:17+00:00

URL: https://externals.io/message/17624#17626 · In reply to: #17624

Hello Rob,

  just a short comment to everyone writing tests: never use '<?' in tests.

marcus

Monday, August 8, 2005, 9:07:24 PM, you wrote:

> Attached is a universal 'diff' that adds a `crc32()` check to the 'passthru'
> test as well as an `md5()` test.  This will help detect if there's a problem
> with `md5()` or `crc32()` unless both are failing, which indicates a problem with
> the 'mhash' functionality.

> Cheers, Rob



Best regards,
 Marcus

---

## #17636 — Rob Vaughn — 2005-08-08T21:59:48+00:00

URL: https://externals.io/message/17624#17636 · In reply to: #17626

Hello,

I didn't write the test, I just added code to check the `crc32()` values, the
rest is the original code.  What should be used instead of '<?' out of
curiousity?  That's all I've ever used.

Marcus Boerger wrote:
> Hello Rob,
> 
>   just a short comment to everyone writing tests: never use '<?' in tests.
> 
> marcus
> 
> Monday, August 8, 2005, 9:07:24 PM, you wrote:
> 
> 
> > […]
> 
> 
> > […]
> 
> 
> 
> 
> Best regards,
>  Marcus

---

## #17637 — Marcus Boerger — 2005-08-08T22:03:19+00:00

URL: https://externals.io/message/17624#17637 · In reply to: #17636

Hello Rob,

Monday, August 8, 2005, 11:59:48 PM, you wrote:

> Hello,

> I didn't write the test, I just added code to check the `crc32()` values, the
> rest is the original code.  What should be used instead of '<?' out of
> curiousity?  That's all I've ever used.

You should use '<?php' since '<?' can be disabled by ini.

Best regards,
 Marcus