# HAVE_INT32_T check in ext/date/lib/timelib_structs.h(php 5.1)

- Thread: https://externals.io/message/16998
- Original archive: https://news-web.php.net/php.internals/16998
- Started by Kamesh Jayachandran on 2005-06-29T12:58:38+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #16998 — Kamesh Jayachandran — 2005-06-29T12:58:38+00:00

URL: https://externals.io/message/16998#16998

Hi Derick,
Who will define HAVE_INT32_T?
I could see ./configure detects it and defines it in main/php_config.h.
But How ext/date/lib/timelib_structs.h know about this?
I could not see ext/date/lib/timelib_structs.h including
main/php_config.h.
#ifndef HAVE_INT32_T
# if SIZEOF_INT == 4
typedef int int32_t;
# elif SIZEOF_LONG == 4
typedef long int int32_t;
# endif
#endif

My NetWare build is breaking because stdio.h which is included after the
above code block also tries to define int32_t which causes a compilation
error.

#include <php_config.h> this at the start of the file(ofcourse after the
guard) solves the problem.

P.S in Zend/zend_strtod.c also we have similar code(checking for
HAVE_INT32_T) there it works because we include
zend_strtod.h->zend.h>zend_config.h->mail/php_config.h), here we don't
have anything of that sort.

Please do the needful.
With regards
Kamesh Jayachandran

-- 
http://www.fastmail.fm - A fast, anti-spam email service.

---

## #17008 — Derick Rethans — 2005-06-29T19:09:31+00:00

URL: https://externals.io/message/16998#17008 · In reply to: #16998

> #include <php_config.h> this at the start of the file(ofcourse after the
> guard) solves the problem.

Should be fixed in CVS, please test.

regards,
Derick

-- 
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

---

## #17031 — Kamesh Jayachandran — 2005-06-30T06:37:57+00:00

URL: https://externals.io/message/16998#17031 · In reply to: #17008

Thanks Derick.
Still have one small issue with it for NetWare.
We decided to use autoconf based build for PHP-5.1 so we don't want to
use config.nw.h(Soon will delete it from the source tree)
This patch takes cares of it.
http://www.ductape.net/~kameshj/ext_date_config.m4.patch

With regards
Kamesh Jayachandran

On Wed, 29 Jun 2005 21:09:31 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:
> 
> 
> > […]
> 
> Should be fixed in CVS, please test.
> 
> regards,
> Derick
> 
> -- 
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

-- 
http://www.fastmail.fm - Access your email from home and the web

---

## #17032 — Derick Rethans — 2005-06-30T06:41:11+00:00

URL: https://externals.io/message/16998#17032 · In reply to: #17031

> Still have one small issue with it for NetWare.
> We decided to use autoconf based build for PHP-5.1 so we don't want to
> use config.nw.h(Soon will delete it from the source tree)
> This patch takes cares of it.
> http://www.ductape.net/~kameshj/ext_date_config.m4.patch

Committed.

Derick

-- 
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

---

## #17033 — Kamesh Jayachandran — 2005-06-30T06:56:06+00:00

URL: https://externals.io/message/16998#17033 · In reply to: #17032

Thanks.
That was so fast.

With regards
Kamesh Jayachandran
On Thu, 30 Jun 2005 08:41:11 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:
> 
> 
> > […]
> 
> Committed.
> 
> Derick
> 
> -- 
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

-- 
http://www.fastmail.fm - Email service worth paying for. Try it for free