# [PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

- Thread: https://externals.io/message/16864
- Original archive: https://news-web.php.net/php.internals/16864
- Started by Antony Dovgal on 2005-06-22T21:28:04+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #16864 — Antony Dovgal — 2005-06-22T21:28:04+00:00

URL: https://externals.io/message/16864#16864

Hello all, hello Andi.

Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983
It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in runtime) to substitute SAPI content-type/charset header.
See the patch in attachment.

-- 
Wbr, 
Antony Dovgal

---

## #16865 — Antony Dovgal — 2005-06-22T21:32:35+00:00

URL: https://externals.io/message/16864#16865 · In reply to: #16864

On Thu, 23 Jun 2005 01:28:04 +0400
Antony Dovgal <antony@zend.com> wrote:

> Hello all, hello Andi.
> 
> Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983
> It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in runtime) to substitute SAPI content-type/charset header.
> See the patch in attachment.

Btw, the same issue applies to default_mimetype too, so I'll cook another one patch (it won't take a lot of time) if this one is ok.

-- 
Wbr, 
Antony Dovgal

---

## #16869 — Ilia Alshanetsky — 2005-06-23T00:20:52+00:00

URL: https://externals.io/message/16864#16869 · In reply to: #16865

Tony,

It looks like you are missing a check to determine if the headers have 
already been sent.

Ilia

---

## #16873 — Andi Gutmans — 2005-06-23T01:50:39+00:00

URL: https://externals.io/message/16864#16873 · In reply to: #16864

I suggest to leave this out of Beta 2 and I'd like to hear feedback from 
others here as to this patch.

Andi

At 01:28 AM 6/23/2005 +0400, Antony Dovgal wrote:
>Hello all, hello Andi.
>
>Andi, I'd like to ask your permission to commit the patch for 
>http://bugs.php.net/bug.php?id=29983
>It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in 
>runtime) to substitute SAPI content-type/charset header.
>See the patch in attachment.
>
>--
>Wbr,
>Antony Dovgal