# Bug 23654: str_replace doesn't handle multidimensional arrays

- Thread: https://externals.io/message/1590
- Original archive: https://news-web.php.net/php.internals/1590
- Started by pollita@php.net on 2003-05-16T17:24:48+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #1590 — pollita@php.net — 2003-05-16T17:24:48+00:00

URL: https://externals.io/message/1590#1590

I've got fixes for str_replace to let it handle multidimensional arrays, but
I'm not sure if it should be applied to the 4.3 branch or not.  On the one
hand it changes function behavior so it shouldn't be applied in stable.  On
the other hand, current behavior is ugly and wrong so it should be fixed..

Thoughts?

-Sara

---

## #1592 — Moriyoshi Koizumi — 2003-05-16T17:39:53+00:00

URL: https://externals.io/message/1590#1592 · In reply to: #1590

<pollita@php.net> wrote:

> I've got fixes for str_replace to let it handle multidimensional arrays, but
> I'm not sure if it should be applied to the 4.3 branch or not.  On the one
> hand it changes function behavior so it shouldn't be applied in stable.  On
> the other hand, current behavior is ugly and wrong so it should be fixed..
> 
> Thoughts?

What is your fix like? Actually the current behaviour is ugly, but I don't 
see the idea `str_replace()` should always be able to handle multi-dim 
arrays as not all the users want it to do so. At most we'd be better off 
if nested arrays were ignored.

Moriyoshi

---

## #1593 — pollita@php.net — 2003-05-16T17:55:37+00:00

URL: https://externals.io/message/1590#1593 · In reply to: #1592

> > […]
but
> > […]
> What is your fix like? Actually the current behaviour is ugly, but I don't
> see the idea `str_replace()` should always be able to handle multi-dim
> arrays as not all the users want it to do so. At most we'd be better off
> if nested arrays were ignored.
>
That may be the better way to go.  The fix I've got will traverse down the
array reentrantly, but it's occured to me that it'll choke on a recursive
array structure (i.e.:   $array[] = &$array; )  That's fixable too of
course, but it starts to get progressively ugly.  Simply patching in this
should do what you describe and keep everyone happy without making a
significant change in branch.  Maybe 5.0 can include an option to traverse
down, maybe not...

Index: ext/standard/string.c
===================================================================
RCS file: /repository/php4/ext/standard/string.c,v
retrieving revision 1.333.2.26
diff -u -r1.333.2.26 string.c
--- ext/standard/string.c       16 May 2003 06:21:39 -0000      1.333.2.26
+++ ext/standard/string.c       16 May 2003 17:52:01 -0000
@@ -2726,8 +2726,12 @@
                /* For each subject entry, convert it to string, then
perform replacement
                   and add the result to the return_value array. */
                while (zend_hash_get_current_data(Z_ARRVAL_PP(subject),
(void **)&subject_entry) == SUCCESS) {
-                       MAKE_STD_ZVAL(result);
-                       php_str_replace_in_subject(*search, *replace,
subject_entry, result);
+                       if (Z_TYPE_PP(subject_entry) != IS_ARRAY &&
Z_TYPE_PP(subject_entry) != IS_OBJECT) {
+                               MAKE_STD_ZVAL(result);
+                               php_str_replace_in_subject(*search,
*replace, subject_entry, result);
+                       } else {
+                               result = *subject_entry;
+                       }
                        /* Add to return array */
                        switch
(zend_hash_get_current_key_ex(Z_ARRVAL_PP(subject), &string_key,

&string_key_len, &num_key, 0, NULL)) {

---

## #1605 — Derick Rethans — 2003-05-16T18:37:36+00:00

URL: https://externals.io/message/1590#1605 · In reply to: #1592

> <pollita@php.net> wrote:
> 
> > […]
> 
> What is your fix like? Actually the current behaviour is ugly, but I don't 
> see the idea `str_replace()` should always be able to handle multi-dim 
> arrays as not all the users want it to do so. At most we'd be better off 
> if nested arrays were ignored.

Agreed on that. Just make it skip arrays for replacements.

Derick

-- 
                                        "my other box is your windows PC"
-------------------------------------------------------------------------
 Derick Rethans                                 http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals       http://php-mag.net/