# PECL Package Proposal: kadm5 - REPOST - Thread: https://externals.io/message/1565 - Original archive: https://news-web.php.net/php.internals/1565 - Started by Holger Burbach on 2003-05-16T13:25:04+00:00 - Messages: 8 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #1565 — Holger Burbach — 2003-05-16T13:25:04+00:00 URL: https://externals.io/message/1565#1565 Hi everyone, I recently developed a new extension to PHP called 'kadm5'. This extension enables you to create, modify, and delete Kerberos V principals and policies on a remote Kerberos Administration server. More information about Kerberos can be found at: http://web.mit.edu/kerberos/www/ There is a new release of kadm5 with some minor changes. The sources can be found at: ftp://oss.gonicus.de/pub/php-kadm5/php-kadm5-0.2.2/ So far I was able to collect 3 votes from pear-dev: +1 "Michael Bretterklieber" +1 "Andrey Hristov" +1 "Yavor Shahpasov" Any other comments? Still need 2 votes... I'm looking forward to integrate this package into PECL. Regards, Holger --- ## #1566 — Sander Roobol — 2003-05-16T13:34:08+00:00 URL: https://externals.io/message/1565#1566 · In reply to: #1565 > There is a new release of kadm5 with some minor changes. The sources can > be found at: > > ftp://oss.gonicus.de/pub/php-kadm5/php-kadm5-0.2.2/ Looks fine, BUT (Derick, still reading? :) * There are some comments from the ext/skel that should (IMO) be removed. Stuff like 'If you have INI entries ...' * The PHP_FUNCTION()s don't have protos. Please add them. * There are some whitespace inconsistancies here and there. Apart from that +1. Sander --- ## #1567 — Derick Rethans — 2003-05-16T13:46:17+00:00 URL: https://externals.io/message/1565#1567 · In reply to: #1566 > > > […] > > Looks fine, BUT (Derick, still reading? :) 1. The biggest problem I see is that the extension is throwing E_ERRORs which extensions really should not do if they do not leave *PHP* in an unstable state (there is also no \n required at the end of the text, and in the best case php_error_docref should be used). 2. Check our CODING STANDARDS file again :) 3. I would recommend to use this naming (As example): kadm5_principal_create kadm5_principal_modify instead of: kadm5_create_principal kadm5_modify_principal 4. There are no prototypes for the PHP_FUNCTIONs 5. There should be atleast one test per function, if possible. 6. The package file has some unescapted entities (the & in "Cleanup in kadm5.c: Removal of confirm_kadm5_compiled & RINIT/RSHUTDOWN" for example) regards, Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- ## #1574 — Holger Burbach — 2003-05-16T15:03:40+00:00 URL: https://externals.io/message/1565#1574 · In reply to: #1567 > > > […] > > 1. The biggest problem I see is that the extension is throwing E_ERRORs > which extensions really should not do if they do not leave *PHP* in > an unstable state (there is also no \n required at the end of the text, > and in the best case php_error_docref should be used). So throwing `E_WARNING` would be better? > 2. Check our CODING STANDARDS file again :) Okay, I'm working on that. > 3. I would recommend to use this naming (As example): > kadm5_principal_create > kadm5_principal_modify > > instead of: > kadm5_create_principal > kadm5_modify_principal Sounds reasonable. > 4. There are no prototypes for the PHP_FUNCTIONs Okay, I'm working on that. > 5. There should be atleast one test per function, if possible. Hmm, to test the functions I have to connect to an Kerberos V administration server... > 6. The package file has some unescapted entities (the & in "Cleanup in > kadm5.c: Removal of confirm_kadm5_compiled & RINIT/RSHUTDOWN" for > example) Well, it seems that I have some things to do... Regards, Holger --- ## #1687 — Derick Rethans — 2003-05-19T08:37:21+00:00 URL: https://externals.io/message/1565#1687 · In reply to: #1574 Hey Holger, > > […] > > So throwing `E_WARNING` would be better? Definitely. (After an `E_WARNING` just return `FALSE` (or NULL)). > > […] > > Okay, I'm working on that. > > > […] > > Sounds reasonable. > > > […] > > Okay, I'm working on that. > > > […] > > Hmm, to test the functions I have to connect to an Kerberos V administration > server... Yeah, I know :) But tests also can work as examples so there is something to gain there. The DBX (ext/dbx) guys figured out something clever to handle cases where the DB server was not available, perhaps you can have a look on how they did it. good luck, Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ --- ## #1880 — Holger Burbach — 2003-05-22T13:04:25+00:00 URL: https://externals.io/message/1565#1880 · In reply to: #1567 Hi Derick, can you please have another look at my PECL module kadm5? I think that I have fixed all the issues you mentioned. Well, hoping to get the final vote "+1" from you. ;-) Thanks in advance. Bye Holger > > > […] > > 1. The biggest problem I see is that the extension is throwing E_ERRORs > which extensions really should not do if they do not leave *PHP* in > an unstable state (there is also no \n required at the end of the text, > and in the best case php_error_docref should be used). Fixed. > 2. Check our CODING STANDARDS file again :) Fixed. At least I hope so ;-) > 3. I would recommend to use this naming (As example): > kadm5_principal_create > kadm5_principal_modify > > instead of: > kadm5_create_principal > kadm5_modify_principal Well, I see your point, but changing the function names gets quite confusing for someone who is familiar with the kadm5 C API. I would prefer to keep them the way they are. > 4. There are no prototypes for the PHP_FUNCTIONs Fixed. > 5. There should be atleast one test per function, if possible. If someone has a clever idea, how to implement these test without accessing a real Kerberos server, I would love to do it. > 6. The package file has some unescapted entities (the & in "Cleanup in > kadm5.c: Removal of confirm_kadm5_compiled & RINIT/RSHUTDOWN" for > example) Fixed. --- ## #1881 — Holger Burbach — 2003-05-22T13:06:52+00:00 URL: https://externals.io/message/1565#1881 · In reply to: #1880 > Hi Derick, > > can you please have another look at my PECL module kadm5? I think that I > have fixed all the issues you mentioned. Sorry, the sources can be found at: ftp://oss.gonicus.de/pub/php/php-kadm5/php-kadm5-0.2.3/ > Well, hoping to get the final vote "+1" from you. ;-) > Thanks in advance. > > Bye > Holger > > > > […] > > Fixed. > > > […] > > Fixed. At least I hope so ;-) > > > […] > > Well, I see your point, but changing the function names gets quite > confusing for someone who is familiar with the kadm5 C API. I would prefer > to keep them the way they are. > > > […] > > Fixed. > > > […] > > If someone has a clever idea, how to implement these test without accessing > a real Kerberos server, I would love to do it. > > > […] > > Fixed. --- ## #1882 — Derick Rethans — 2003-05-22T13:10:39+00:00 URL: https://externals.io/message/1565#1882 · In reply to: #1881 > > […] > > Sorry, the sources can be found at: > > ftp://oss.gonicus.de/pub/php/php-kadm5/php-kadm5-0.2.3/ I'll have a look when I get home. Derick -- ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/