# Two minor issues in 5.0.4

- Thread: https://externals.io/message/15624
- Original archive: https://news-web.php.net/php.internals/15624
- Started by Antony Dovgal on 2005-03-26T10:05:56+00:00
- Messages: 6
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #15624 — Antony Dovgal — 2005-03-26T10:05:56+00:00

URL: https://externals.io/message/15624#15624

Hi all!

I'd like to fix two minor issues before releasing 5.0.4.

These issues are:
1) mmap'ed files are bound to 2M.
In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to 2000000.
That causes `readfile()` to read only 2Mb and stop (which is rather frustrating).
See main/php_streams.h

2) `output_reset_rewrite_vars()` *always* returns false.
See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
IMO it's just a silly typo, but this routine returns FAILURE in any case.
The very same problem actually exists in all other branches too

If nobody objects, I'll fix both issues in the evening.
 
-- 
Wbr, 
Antony Dovgal aka tony2001
antony@zend.com

---

## #15625 — Vadka — 2005-03-26T19:34:29+00:00

URL: https://externals.io/message/15624#15625 · In reply to: #15624

Hi all!

So, as it was stressed in expat one day, there are 'empty' tags, like:
<foo val=''/>
(without ending </foo>).
For now, it is not known what a tag was parsed (XML parser ext).
It is not good: the original structure of XML changes.

---

## #15634 — Antony Dovgal — 2005-03-27T11:55:56+00:00

URL: https://externals.io/message/15624#15634 · In reply to: #15624

On Sat, 26 Mar 2005 13:05:56 +0300
Antony Dovgal <antony@zend.com> wrote:

> Hi all!
> 
> I'd like to fix two minor issues before releasing 5.0.4.
> 
> These issues are:
> 1) mmap'ed files are bound to 2M.
> In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to 2000000.
> That causes `readfile()` to read only 2Mb and stop (which is rather frustrating).
> See main/php_streams.h
> 
> 2) `output_reset_rewrite_vars()` *always* returns false.
> See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re,
> IMO it's just a silly typo, but this routine returns FAILURE in any case.
> The very same problem actually exists in all other branches too
> 
> If nobody objects, I'll fix both issues in the evening.

Ilia, Zeev, any objections?

-- 
Wbr, 
Antony Dovgal aka tony2001
antony@zend.com

---

## #15635 — Zeev Suraski — 2005-03-27T12:51:09+00:00

URL: https://externals.io/message/15624#15635 · In reply to: #15624

At 13:55 27/03/2005, Antony Dovgal wrote:
>On Sat, 26 Mar 2005 13:05:56 +0300
>Antony Dovgal <antony@zend.com> wrote:
>
> > […]
> 5.0.4 it is set to 2000000.
> > […]
> frustrating).
> > […]

Wez - is that safe to MFH it to the 5_0 branch 
(http://www.mail-archive.com/php-cvs@lists.php.net/msg15050.html)?

> > […]

How are you planning to change it?

Zeev

---

## #15636 — Antony Dovgal — 2005-03-27T12:57:36+00:00

URL: https://externals.io/message/15624#15636 · In reply to: #15635

On Sun, 27 Mar 2005 14:51:09 +0200
Zeev Suraski <zeev@zend.com> wrote:

> How are you planning to change it?

See the diffs attached.

-- 
Wbr, 
Antony Dovgal aka tony2001
antony@zend.com

---

## #15638 — Davey — 2005-03-27T17:16:53+00:00

URL: https://externals.io/message/15624#15638 · In reply to: #15625

Vadka wrote:
> 
> Hi all!
> 
> So, as it was stressed in expat one day, there are 'empty' tags, like:
> <foo val=''/>
> (without ending </foo>).
> For now, it is not known what a tag was parsed (XML parser ext).
> It is not good: the original structure of XML changes.

In XML, <foo /> and <foo></foo> are identical as far as semantics are 
concerned. This is nothing to worry about IMO - any decent XML parser
treats them the same.

- Davey