# [PATCH] 5.0/Zend memset fix

- Thread: https://externals.io/message/15521
- Original archive: https://news-web.php.net/php.internals/15521
- Started by Joe Orton on 2005-03-21T09:36:41+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #15521 — Joe Orton — 2005-03-21T09:36:41+00:00

URL: https://externals.io/message/15521#15521

Found by Dave Jones grepping for memset(,,0)... only applies to the 5.0
branch: either correct it as below or remove the line completely?

Index: zend_execute.c
===================================================================
RCS file: /repository/ZendEngine2/zend_execute.c,v
retrieving revision 1.652.2.21
diff -u -r1.652.2.21 zend_execute.c
--- zend_execute.c	10 Mar 2005 02:34:11 -0000	1.652.2.21
+++ zend_execute.c	21 Mar 2005 09:32:39 -0000
@@ -4316,7 +4316,7 @@
 
 void zend_init_opcodes_handlers()
 {
-	memset(zend_opcode_handlers, sizeof(zend_opcode_handlers), 0);
+	memset(zend_opcode_handlers, 0, sizeof(zend_opcode_handlers));
 	zend_opcode_handlers[ZEND_NOP] = zend_nop_handler;
 	zend_opcode_handlers[ZEND_ADD] = zend_add_handler;
 	zend_opcode_handlers[ZEND_SUB] = zend_sub_handler;

---

## #15523 — Andi Gutmans — 2005-03-21T16:22:13+00:00

URL: https://externals.io/message/15521#15523 · In reply to: #15521

Commited. Thanks.

At 09:36 AM 3/21/2005 +0000, Joe Orton wrote:
>Found by Dave Jones grepping for memset(,,0)... only applies to the 5.0
>branch: either correct it as below or remove the line completely?
>
>Index: zend_execute.c
>===================================================================
>RCS file: /repository/ZendEngine2/zend_execute.c,v
>retrieving revision 1.652.2.21
>diff -u -r1.652.2.21 zend_execute.c
>--- zend_execute.c      10 Mar 2005 02:34:11 -0000      1.652.2.21
>+++ zend_execute.c      21 Mar 2005 09:32:39 -0000
>@@ -4316,7 +4316,7 @@
>
>  void zend_init_opcodes_handlers()
>  {
>-       memset(zend_opcode_handlers, sizeof(zend_opcode_handlers), 0);
>+       memset(zend_opcode_handlers, 0, sizeof(zend_opcode_handlers));
>         zend_opcode_handlers[ZEND_NOP] = zend_nop_handler;
>         zend_opcode_handlers[ZEND_ADD] = zend_add_handler;
>         zend_opcode_handlers[ZEND_SUB] = zend_sub_handler;