# Win32 builds are broken

- Thread: https://externals.io/message/15037
- Original archive: https://news-web.php.net/php.internals/15037
- Started by Frank M. Kromann on 2005-02-17T04:56:50+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #15037 — Frank M. Kromann — 2005-02-17T04:56:50+00:00

URL: https://externals.io/message/15037#15037

Hi Andi,

Here is the diff I send to Markus earlier today. Not sure why this works
and the original does'nt.

cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite\)
Index: sqlite.c
===================================================================
RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
retrieving revision 1.157
diff -u -w -b -r1.157 sqlite.c
--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
+++ sqlite.c 17 Feb 2005 00:47:36 -0000
@@ -1015,7 +1015,9 @@
sqlite_ce_ub_query->iterator_funcs.funcs =
&sqlite_ub_query_iterator_funcs;

#ifdef HAVE_SPL
- zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
spl_ce_Countable);
+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
+// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
spl_ce_Countable);
#else
zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); 
#endif

- Frank


> Can you send the diff of that commit?
> 
> At 16:35 16/02/2005 -0800, Frank M. Kromann wrote:
> > […]
to
> > […]
far I
> > […]

---

## #15064 — Andi Gutmans — 2005-02-17T20:25:00+00:00

URL: https://externals.io/message/15037#15064 · In reply to: #15037

I took a look at the code and I can't see why it wouldn't work. I lost my 
VC++ environment recently because my machine died. Maybe someone else can 
try and see what's going on until I rebuild mine.

Andi

At 08:56 PM 2/16/2005 -0800, Frank M. Kromann wrote:
>Hi Andi,
>
>Here is the diff I send to Markus earlier today. Not sure why this works
>and the original does'nt.
>
>cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite\)
>Index: sqlite.c
>===================================================================
>RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
>retrieving revision 1.157
>diff -u -w -b -r1.157 sqlite.c
>--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
>+++ sqlite.c 17 Feb 2005 00:47:36 -0000
>@@ -1015,7 +1015,9 @@
>sqlite_ce_ub_query->iterator_funcs.funcs =
>&sqlite_ub_query_iterator_funcs;
>
>#ifdef HAVE_SPL
>- zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
>spl_ce_Countable);
>+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
>+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
>+// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
>spl_ce_Countable);
>#else
>zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
>#endif
>
>- Frank
>
>
> > […]
>to
> > […]
>far I
> > […]

---

## #15066 — Andi Gutmans — 2005-02-17T20:27:09+00:00

URL: https://externals.io/message/15037#15066 · In reply to: #15037

I see Marcus found the problem. Definitely required a compiler to find this 
problem :)

At 12:25 PM 2/17/2005 -0800, Andi Gutmans wrote:
>I took a look at the code and I can't see why it wouldn't work. I lost my 
>VC++ environment recently because my machine died. Maybe someone else can 
>try and see what's going on until I rebuild mine.
>
>Andi
>
>At 08:56 PM 2/16/2005 -0800, Frank M. Kromann wrote:
> > […]

---

## #15069 — Marcus Boerger — 2005-02-17T21:07:36+00:00

URL: https://externals.io/message/15037#15069 · In reply to: #15037

Hello Frank,

  the problem turned out to be a possible memory reallocation/size
evaluation violation. After switching some times between *nix and
windows i think i have solved the issue completeley now.

regards
marcus

Thursday, February 17, 2005, 5:56:50 AM, you wrote:

> Hi Andi,

> Here is the diff I send to Markus earlier today. Not sure why this works
> and the original does'nt.

> cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite\)
> Index: sqlite.c
> ===================================================================
> RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
> retrieving revision 1.157
> diff -u -w -b -r1.157 sqlite.c
> --- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
> +++ sqlite.c 17 Feb 2005 00:47:36 -0000
> @@ -1015,7 +1015,9 @@
> sqlite_ce_ub_query->iterator_funcs.funcs =
> &sqlite_ub_query_iterator_funcs;

> #ifdef HAVE_SPL
> - zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
> spl_ce_Countable);
> + zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
> + zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
> +// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
> spl_ce_Countable);
> #else
> zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); 
> #endif

> - Frank


> > […]
> to
> > […]
> far I
> > […]




-- 
Best regards,
 Marcus                            mailto:helly@php.net