# Reversion of patch for bug #31398

- Thread: https://externals.io/message/14419
- Original archive: https://news-web.php.net/php.internals/14419
- Started by Moriyoshi Koizumi on 2005-01-23T22:04:31+00:00
- Messages: 1
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #14419 — Moriyoshi Koizumi — 2005-01-23T22:04:31+00:00

URL: https://externals.io/message/14419#14419

Ilia,

While your opinion that we shouldn't count on the "filename"
attribute in multiparted queries is quite to the point,
your patch totally disregards the old behaviour.

We must neither use php_basename() for pathes of a spec
different from that defined by the platform which is determined
in compile time. That most likely leads to inconsistent behaviour
between platforms.

In addition, you had removed the portion Rui added in the past
that allowed multibyte-encoded filenames to get parsed properly
without any notice. Actually the function in question doesn't
work at all with such filenames at this momemnt.

Due to those issues, I'm going to revert your patch and recommit
less radical one.

Regards,
Moriyoshi