# Readline compile failure

- Thread: https://externals.io/message/12995
- Original archive: https://news-web.php.net/php.internals/12995
- Started by Timm Friebe on 2004-09-26T10:13:38+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #12995 — Timm Friebe — 2004-09-26T10:13:38+00:00

URL: https://externals.io/message/12995#12995

Hi,
here's a patch that fixes the following:

In file included from
/usr/home/thekid/devel/php/php/ext/readline/readline.c:28:
/usr/home/thekid/devel/php/php/ext/readline/php_readline.h:26: warning:
#warning Readline module will *NEVER* be thread-safe
/usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
`_readline_completion_cb':
/usr/home/thekid/devel/php/php/ext/readline/readline.c:423: warning:
passing arg 1 of `completion_matches' discards qualifiers from pointer
target type
/usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
`zif_readline_completion_function':
/usr/home/thekid/devel/php/php/ext/readline/readline.c:443: syntax error
before `char'
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: `name'
undeclared (first use in this function)
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: (Each
undeclared identifier is reported only once
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: for each
function it appears in.)
*** Error code 1

Stop in /usr/home/thekid/devel/php/php.

- Timm

---

## #12996 — Wez Furlong — 2004-09-26T13:52:38+00:00

URL: https://externals.io/message/12995#12996 · In reply to: #12995

Committed; thanks!



> Hi,
> here's a patch that fixes the following:
> 
> In file included from
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:28:
> /usr/home/thekid/devel/php/php/ext/readline/php_readline.h:26: warning:
> #warning Readline module will *NEVER* be thread-safe
> /usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
> `_readline_completion_cb':
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:423: warning:
> passing arg 1 of `completion_matches' discards qualifiers from pointer
> target type
> /usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
> `zif_readline_completion_function':
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:443: syntax error
> before `char'
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:444: `name'
> undeclared (first use in this function)
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:444: (Each
> undeclared identifier is reported only once
> /usr/home/thekid/devel/php/php/ext/readline/readline.c:444: for each
> function it appears in.)
> *** Error code 1
> 
> Stop in /usr/home/thekid/devel/php/php.
> 
> - Timm