# [PATCH] ok this works in all cases and smells right

- Thread: https://externals.io/message/12770
- Original archive: https://news-web.php.net/php.internals/12770
- Started by Steph on 2004-09-13T17:55:14+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #12770 — Steph — 2004-09-13T17:55:14+00:00

URL: https://externals.io/message/12770#12770

BTW shouldn't main/config.w32.h be in .cvsignore?

- Steph

---

## #12774 — Wez Furlong — 2004-09-13T18:37:43+00:00

URL: https://externals.io/message/12770#12774 · In reply to: #12770

> BTW shouldn't main/config.w32.h be in .cvsignore?

Ideally, yes, but it's still used as-is by the .dsp build system

Your patch looks much better (note that the # character for #define's
and #ifdefs etc. should start in the left-most column, otherwise some
weirdo compilers will break).

--Wez.

---

## #12776 — Derick Rethans — 2004-09-13T18:45:12+00:00

URL: https://externals.io/message/12770#12776 · In reply to: #12770

> BTW shouldn't main/config.w32.h be in .cvsignore?

This patch is wrong, the #if HAVE_STRCOLL should be there in all places,
also, I did not guard the constant registration as that can always be
available just fine.

Derick

-- 
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org