# [PATCH] bug #29336

- Thread: https://externals.io/message/11562
- Original archive: https://news-web.php.net/php.internals/11562
- Started by Antony Dovgal on 2004-07-26T06:49:37+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #11562 — Antony Dovgal — 2004-07-26T06:49:37+00:00

URL: https://externals.io/message/11562#11562

Hi all!

Plz, take a look at bug #29336 ( http://bugs.php.net/29336 for lazy
ones =)). 
HEAD segfaults on `session_start()` after empty_string ->
STR_EMPTY_ALLOC() change. This happens because SID constant gets
initialized with "" string instead of STR_EMPTY_ALLOC().

The patch: http://tony2004.phpclub.net/dev/tmp/session.diff seems to
be the solution.

Another one issue, that is being fixed by this patch, is false memory
leak message ("Freeing 0 bytes blah-blah"), similar to this:
http://lists.php.net/php.zend-engine.cvs/2796 issue.

Is there any comments/objections against the patch?

---
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net || antony@dovgal.com

---

## #11567 — Sascha Schumann — 2004-07-26T07:58:01+00:00

URL: https://externals.io/message/11562#11567 · In reply to: #11562

> Hi all!
>
> Plz, take a look at bug #29336 ( http://bugs.php.net/29336 for lazy
> ones =)).
> HEAD segfaults on `session_start()` after empty_string ->
> STR_EMPTY_ALLOC() change. This happens because SID constant gets
> initialized with "" string instead of STR_EMPTY_ALLOC().
>
> The patch: http://tony2004.phpclub.net/dev/tmp/session.diff seems to
> be the solution.

     The second part regarding session.c is ok.

> Another one issue, that is being fixed by this patch, is false memory
> leak message ("Freeing 0 bytes blah-blah"), similar to this:
> http://lists.php.net/php.zend-engine.cvs/2796 issue.

     The read process should just be skipped, if the file has zero
     length.  I'll look into this later this day.

     - Sascha

---

## #11568 — Antony Dovgal — 2004-07-26T08:04:43+00:00

URL: https://externals.io/message/11562#11568 · In reply to: #11567

On Mon, 26 Jul 2004 09:58:01 +0200 (CEST)
Sascha Schumann <sascha@schumann.cx> wrote:

> 
> 
> > […]
> 
>      The second part regarding session.c is ok.

commit, please? =)

> > […]
> 
>      The read process should just be skipped, if the file has zero
>      length.  I'll look into this later this day.

ok, thanks.

---
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net || antony@dovgal.com