# php_compat.h in ext/mbstring/oniguruma

- Thread: https://externals.io/message/11323
- Original archive: https://news-web.php.net/php.internals/11323
- Started by Joe Orton on 2004-07-18T13:13:06+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #11323 — Joe Orton — 2004-07-18T13:13:06+00:00

URL: https://externals.io/message/11323#11323

I think this file needs to be renamed; the 5.0.0 build fails using
mbregex and pcre with bundled pcre, for instance, since the bundled pcre
picks up the wrong php_compat.h and the #define pcre_* aren't picked up.

Renaming it to php_oniguruma.h and changing the #include fixes the
build.

Index: oniguruma.h
===================================================================
RCS file: /repository/php-src/ext/mbstring/oniguruma/oniguruma.h,v
retrieving revision 1.3
diff -u -r1.3 oniguruma.h
--- oniguruma.h	4 Mar 2004 21:50:20 -0000	1.3
+++ oniguruma.h	18 Jul 2004 13:11:50 -0000
@@ -8,7 +8,7 @@
 #ifndef ONIGURUMA_H
 #define ONIGURUMA_H
 
-#include "php_compat.h"
+#include "php_oniguruma.h"
 
 #define ONIGURUMA
 #define ONIGURUMA_VERSION_MAJOR   2


joe

---

## #11332 — Moriyoshi Koizumi — 2004-07-19T05:13:11+00:00

URL: https://externals.io/message/11323#11332 · In reply to: #11323

done (VPATH fix applied as well).

Joe Orton wrote:

>I think this file needs to be renamed; the 5.0.0 build fails using
>mbregex and pcre with bundled pcre, for instance, since the bundled pcre
>picks up the wrong php_compat.h and the #define pcre_* aren't picked up.
>
>Renaming it to php_oniguruma.h and changing the #include fixes the
>build.