# Using [ci skip] - Thread: https://externals.io/message/105854 - Original archive: https://news-web.php.net/php.internals/105854 - Started by Joe Watkins on 2019-06-07T10:50:52+00:00 - Messages: 8 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #105854 — Joe Watkins — 2019-06-07T10:50:52+00:00 URL: https://externals.io/message/105854#105854 Hi all, Just a friendly reminder that when we're committing changes to files that do not contain source, test code, or build configuration, it's helpful to include [ci skip] in the commit message. Omitting it can put our CI quite far behind. Cheers Joe --- ## #105855 — Marco Pivetta — 2019-06-07T11:02:00+00:00 URL: https://externals.io/message/105854#105855 Please avoid doing that: 1. Commit messages are for humans 2. You never know what can break, that's why it's "continuous" there (besides religious views around what "continuous integration" means) > Hi all, > > Just a friendly reminder that when we're committing changes to files that > do not contain source, test code, or build configuration, it's helpful to > include [ci skip] in the commit message. Omitting it can put our CI quite > far behind. > > Cheers > Joe --- ## #105856 — Joe Watkins — 2019-06-07T11:07:39+00:00 URL: https://externals.io/message/105854#105856 Hi Marco, It wasn't a topic for discussion, it was a request to committers in php-src. We do not need to run CI for NEWS changes, and we can definitely be sure it doesn't effect the build. The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... Under normal circumstances these files are not changed by themslves, but occasionally, we have to correct one of these files and omitting [ci ski] puts the build behind by up to an hour ... Cheers Joe > Please avoid doing that: > > 1. Commit messages are for humans > 2. You never know what can break, that's why it's "continuous" there > (besides religious views around what "continuous integration" means) > > > > > […] --- ## #105857 — Joe Watkins — 2019-06-07T11:09:00+00:00 URL: https://externals.io/message/105854#105857 Oh to be absolutely clear, I'm talking about commits that *only* touch these non-source files ... Cheers Joe > Hi Marco, > > It wasn't a topic for discussion, it was a request to committers in > php-src. > > We do not need to run CI for NEWS changes, and we can definitely be sure > it doesn't effect the build. > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... > > Under normal circumstances these files are not changed by themslves, but > occasionally, we have to correct one of these files and omitting [ci ski] > puts the build behind by up to an hour ... > > Cheers > Joe > > > > > […] --- ## #105858 — Peter Cowburn — 2019-06-07T14:00:20+00:00 URL: https://externals.io/message/105854#105858 > Oh to be absolutely clear, I'm talking about commits that *only* touch > these non-source files ... > > Cheers > Joe > > > > > […] > Is this documented somewhere? I'm not seeing it in the docs held in php-src, nor a search of the wiki, for example. Also, is this not something that the CI application(s) can be configured to do for us? > > […] --- ## #105859 — Nikita Popov — 2019-06-07T14:06:25+00:00 URL: https://externals.io/message/105854#105859 > > > > […] > sure > > […] > but > > […] > ski] > > […] > helpful > > […] > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured to > do for us? > That's a good point. It looks like the option exists: https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops&tabs=yaml#paths I think we used something like this on AppVeyor at some time, but had to disable it for some reason (?) Nikita --- ## #105860 — Joe Watkins — 2019-06-07T14:07:19+00:00 URL: https://externals.io/message/105854#105860 Hi Peter, I think it's pretty well known about, but don't think we have it written down anywhere. I could make a note of it somewhere. I think in the case of azure it can be configured but I'm not sure about the others. I'll try to find out. Cheers Joe > > > > > > […] > > Is this documented somewhere? I'm not seeing it in the docs held in > php-src, nor a search of the wiki, for example. > Also, is this not something that the CI application(s) can be configured > to do for us? > > > > […] --- ## #105875 — Scott Dutton — 2019-06-12T01:31:55+00:00 URL: https://externals.io/message/105854#105875 Hi Joe Is there any reason why something like the following isnt run instead ? runTests=$(git diff origin/master... --name-only --diff-filter=ACMR -- ':(exclude)docs/*' | wc -l) if [[ "${runTests}" -gt 0 ]]; then ./run-tests.sh fi ~ Which says if the diff contains files outside of /docs then run the tests. Contributors can then forget about the [ci-skip] and gets the same effect This runs on linux but I cant imagine its a big change to make for this to work on windows ? You can tweak the diff command to only run tests when certain sets of files change Thanks Scott > Hi Peter, > > I think it's pretty well known about, but don't think we have it > written > down anywhere. I could make a note of it somewhere. > > I think in the case of azure it can be configured but I'm not sure > about > the others. I'll try to find out. > > Cheers > Joe > > On Fri, 7 Jun 2019 at 16:00, Peter Cowburn > wrote: > > > […]