# PHP 7.3 dom change?

- Thread: https://externals.io/message/105029
- Original archive: https://news-web.php.net/php.internals/105029
- Started by Rasmus Lerdorf on 2019-04-01T16:25:21+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #105029 — Rasmus Lerdorf — 2019-04-01T16:25:21+00:00

URL: https://externals.io/message/105029#105029

I've been walking through the PHP 7.2->7.3 ext/dom diffs but I don't see
what has caused this change: https://3v4l.org/hEmmR
What did I miss?

-Rasmus

---

## #105030 — Rasmus Lerdorf — 2019-04-01T20:42:58+00:00

URL: https://externals.io/message/105029#105030

> I've been walking through the PHP 7.2->7.3 ext/dom diffs but I don't see
> what has caused this change: https://3v4l.org/hEmmR
> What did I miss?
>

Tracked it down to this bug fix:  https://bugs.php.net/76285

-Rasmus

---

## #105033 — Anatol Belski — 2019-04-02T09:22:10+00:00

URL: https://externals.io/message/105029#105033

> On Mon, Apr 1, 2019 at 9:25 AM Rasmus Lerdorf <rasmus@lerdorf.com>
> wrote:
> 
> > […]
> 
> Tracked it down to this bug fix:  https://bugs.php.net/76285
> 
Ah, I recall this one now. It was about saveHtml() not respecting
format, had some follow ups, too. Should be harmless but might breach
some test. Please ping, if there is a further issue.

Regards

Anatol

---

## #105036 — Rasmus Lerdorf — 2019-04-02T14:08:49+00:00

URL: https://externals.io/message/105029#105036

> 
> > […]
> Ah, I recall this one now. It was about saveHtml() not respecting
> format, had some follow ups, too. Should be harmless but might breach
> some test. Please ping, if there is a further issue.
>

Yeah, it broke some tests and there is no mention of it in the migration
docs.

-Rasmus