# RFC Proposal: Make the hash extension always available

- Thread: https://externals.io/message/103120
- Original archive: https://news-web.php.net/php.internals/103120
- Started by Kalle Sommer Nielsen on 2018-09-04T09:11:34+00:00
- Messages: 4
- RFC: Always available hash extension (Implemented (PHP 7.4)) — https://externals.io/rfc/permanent_hash_ext.md
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · RFCs at https://externals.io/rfc.md · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #103120 — Kalle Sommer Nielsen — 2018-09-04T09:11:34+00:00

URL: https://externals.io/message/103120#103120

Gday fellow hackers

I just posted an RFC and set it up for discussion[1], this proposes to
make the ext/hash extension always enabled, similar to that for date,
spl & pcre.

Comments are welcome. I intend to start voting in 2-3 weeks time,
should there be no critical issues in regards to this RFC.


[1] https://wiki.php.net/rfc/permanent_hash_ext

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net

---

## #103121 — Christoph M. Becker — 2018-09-04T10:20:25+00:00

URL: https://externals.io/message/103120#103121 · In reply to: #103120

> I just posted an RFC and set it up for discussion[1], this proposes to
> make the ext/hash extension always enabled, similar to that for date,
> spl & pcre.
> 
> Comments are welcome. I intend to start voting in 2-3 weeks time,
> should there be no critical issues in regards to this RFC.
> 
> 
> [1] https://wiki.php.net/rfc/permanent_hash_ext

That appears to be sensible.  Anyhow, *if* we do this, we also should
move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
SHA1 is currently dead code in ext/hash, and the CRC32 implementation
seems to be duplicated).  We should also have a look at crypt_sha256.c
and crypt_sha512.c (of ext/standard) which likely duplicate some code
already available in ext/hash.

-- 
Christoph M. Becker

---

## #103122 — Kalle Sommer Nielsen — 2018-09-04T10:38:28+00:00

URL: https://externals.io/message/103120#103122 · In reply to: #103121

Den tir. 4. sep. 2018 kl. 12.20 skrev Christoph M. Becker <cmbecker69@gmx.de>:
> That appears to be sensible.  Anyhow, *if* we do this, we also should
> move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
> SHA1 is currently dead code in ext/hash, and the CRC32 implementation
> seems to be duplicated).  We should also have a look at crypt_sha256.c
> and crypt_sha512.c (of ext/standard) which likely duplicate some code
> already available in ext/hash.

Those makes a lot of sense to do, and definitely something we should
if this RFC passes


-- 
regards,

Kalle Sommer Nielsen
kalle@php.net

---

## #103126 — Sara Golemon — 2018-09-04T16:19:07+00:00

URL: https://externals.io/message/103120#103126 · In reply to: #103120

> I just posted an RFC and set it up for discussion[1], this proposes to
> make the ext/hash extension always enabled, similar to that for date,
> spl & pcre.
>
> Comments are welcome. I intend to start voting in 2-3 weeks time,
> should there be no critical issues in regards to this RFC.
>
As ext/hash's original author, I always dreamed this day would come.
