# default_encoding RFC – aftermath - Thread: https://externals.io/message/103087 - Original archive: https://news-web.php.net/php.internals/103087 - Started by Christoph M. Becker on 2018-08-12T17:00:02+00:00 - Messages: 4 - RFC: Default character encoding (Implemented (PHP 5.6)) — https://externals.io/rfc/default_encoding.md - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · RFCs at https://externals.io/rfc.md · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #103087 — Christoph M. Becker — 2018-08-12T17:00:02+00:00 URL: https://externals.io/message/103087#103087 Hi! Quite a while ago we have accepted the “Use default_charset As Default Character Encoding” RFC[1], which also contains the clause “Old iconv.*/mbstring.* php.ini parameters will be removed for master PHP6” (obviously that was written before we decided to skip PHP 6, and as such would have to be applied to PHP 7). I'm quite happy, though, that this hasn't happened yet, since it seems that the encoding names may be different between the extensions. At least the php.net manual states[2]: | Some systems (like IBM AIX) use "ISO8859-1" instead of "ISO-8859-1" so | this value has to be used in configuration options and function | parameters. It appears to be worthwhile to review the deprecation of the respective iconv.* ini options. Not quite sure about the mbstring.* ini options. Also, if we stick with the deprecation of the iconv.* ini settings, we also should deprecate `iconv_set_encoding()`, which currently changes the deprecated iconv.* ini options, and as such throws a deprecation warning. However, if the ini options would be removed, what should the function do? Nothing? Change the php.*_encoding settings. In my opinion, both would be rather confusing. `iconv_get_encoding()` has a similar, albeit minor, issue. [1] [2] -- Christoph M. Becker --- ## #103088 — Andrea Faulds — 2018-08-12T17:57:40+00:00 URL: https://externals.io/message/103087#103088 · In reply to: #103087 Hi Cristoph, Christoph M. Becker wrote: > I'm quite happy, though, that this > hasn't happened yet, since it seems that the encoding names may be > different between the extensions. At least the php.net manual states[2]: > > | Some systems (like IBM AIX) use "ISO8859-1" instead of "ISO-8859-1" so > | this value has to be used in configuration options and function > | parameters. > > It appears to be worthwhile to review the deprecation of the respective > iconv.* ini options. Not quite sure about the mbstring.* ini options. Could this not be solved by making all the extensions support all the encoding name aliases or so? That wouldn't be difficult to implement and wouldn't break anything. Thanks! -- Andrea Faulds https://ajf.me/ --- ## #103089 — Christoph M. Becker — 2018-08-12T21:11:01+00:00 URL: https://externals.io/message/103087#103089 · In reply to: #103088 Hi Andrea! > Christoph M. Becker wrote: > > > […] > > Could this not be solved by making all the extensions support all the > encoding name aliases or so? That wouldn't be difficult to implement and > wouldn't break anything. I think that would only be possible, if we knew how they have to be mapped. Consider the AIX example above; I'm not even sure if this is (still) valid, but should we have special maps for AIX? Should we try to detect this during configuration? I'm not sure if that's even reliably possible, since some iconv implementations (which ones?) do not support errno[1], so we can't detect whether iconv_open() failed with EINVAL, or some other error. As it is now, it's simply up to the user to pass a supported encoding name. [1] -- Christoph M. Becker --- ## #103091 — Nikita Popov — 2018-08-13T08:26:29+00:00 URL: https://externals.io/message/103087#103091 · In reply to: #103087 On Sun, Aug 12, 2018 at 7:00 PM, Christoph M. Becker wrote: > Hi! > > Quite a while ago we have accepted the “Use default_charset As Default > Character Encoding” RFC[1], which also contains the clause “Old > iconv.*/mbstring.* php.ini parameters will be removed for master PHP6” > (obviously that was written before we decided to skip PHP 6, and as such > would have to be applied to PHP 7). I'm quite happy, though, that this > hasn't happened yet, since it seems that the encoding names may be > different between the extensions. At least the php.net manual states[2]: > > | Some systems (like IBM AIX) use "ISO8859-1" instead of "ISO-8859-1" so > | this value has to be used in configuration options and function > | parameters. > > It appears to be worthwhile to review the deprecation of the respective > iconv.* ini options. Not quite sure about the mbstring.* ini options. > > Also, if we stick with the deprecation of the iconv.* ini settings, we > also should deprecate `iconv_set_encoding()`, which currently changes the > deprecated iconv.* ini options, and as such throws a deprecation > warning. However, if the ini options would be removed, what should the > function do? Nothing? Change the php.*_encoding settings. In my > opinion, both would be rather confusing. `iconv_get_encoding()` has a > similar, albeit minor, issue. > > [1] > [2] > IIRC the new ini settings also don't work with Zend Multibyte yet. That would need to be fixed before we drop them. Nikita