# Merging LDAP controls support

- Thread: https://externals.io/message/100543
- Original archive: https://news-web.php.net/php.internals/100543
- Started by come@opensides.be on 2017-09-12T15:39:51+00:00
- Messages: 1
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #100543 — come@opensides.be — 2017-09-12T15:39:51+00:00

URL: https://externals.io/message/100543#100543

Hello,

I’m getting close to have something I can merge in master for my PR adding support for LDAP controls: https://github.com/php/php-src/pull/2640

In this case am I suppose to squash the changes in a single commit? This was suggested to me for a previous PR but there is so much changes here I feel we should keep the history.

If some of you can pull my branch and launch the tests from ext/ldap it would help. You’ll need an LDAP server and to fill the env vars from ext/ldap/tests/connect.inc.

Côme