Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99930
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAB8JV1N4vs38FUtNEqSrbe0Pzt7uRWuw5yBE=YCvtg08J8R3ow@mail.gmail.com>
References: <CAB8JV1N4vs38FUtNEqSrbe0Pzt7uRWuw5yBE=YCvtg08J8R3ow@mail.gmail.com>
Date: Wed, 19 Jul 2017 10:11:24 +0200
Message-ID: <CADyq6s+HLfdEQV=7cTimoky=YhuOr7cXELh=UT8U2dpKo+xxjQ@mail.gmail.com>
To: =?UTF-8?Q?Bart=C5=82omiej_Krukowski?= <krukowski.bartlomiej@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a113aa4f4c7b5890554a72eac"
Subject: Re: [PHP-DEV] RFC - ReflectionProperty calls __get methods
From: ocramius@gmail.com (Marco Pivetta)

--001a113aa4f4c7b5890554a72eac
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 19, 2017 at 9:53 AM, Bart=C5=82omiej Krukowski <
krukowski.bartlomiej@gmail.com> wrote:

> Hello,
>
> Class *ReflectionProperty* allows to get access to private properties in
> library. Unfortunately there is one unexpected (or at least undocumented)
> case - *ReflectionProperty* tries execute *__call* method. In my opinion
> this approach is bad, because method *__call* can change state of
> application (I'd like to read value, not execute code).


This is expected behavior - the reflection API does not work around the
rules of the engine, just the rules of scope (like closures do).

See https://bugs.php.net/bug.php?id=3D63463 for a very similar report that
was discussed and marked as "not a bug" ages ago.


> I'd like to suggest
> different approach:
>
>
>    - Method *ReflectionProperty->getValue* will throw exception when
>    property is removed.
>

It should just call `__get` as before - see also
https://bugs.php.net/bug.php?id=3D72174 and https://github.com/php/php-
src/commit/a1ed4ab3caf33b59742897b43462d033864bb490 - reflection shouldn't
check if the property exists upfront.


>    - Class *ReflectionProperty* will receive new method - *exists*.
>

You can already use `array_key_exists($propertyFqn, (array) $object);` for
that.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a113aa4f4c7b5890554a72eac--