Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99892
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender)
To: Anatol Belski <weltling@outlook.de>, Dan Ackroyd <danack@basereality.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
References: <CA+kxMuTFNzu=UAL_41CeW=M9DDjpfS4Ujz6gBee4MwxU34CvaA@mail.gmail.com>
 <8777af5c-83d2-6688-b8b1-b5898f8deda3@gmx.de>
 <CA+kxMuT1Fv1ye57csPg4P0HFBYHEV8ATPQn_36E1jHD+x8Dhww@mail.gmail.com>
 <HE1PR02MB10520713B65DBED2C10AEAA8BAA10@HE1PR02MB1052.eurprd02.prod.outlook.com>
Message-ID: <cd368f0d-a3d0-f10f-0668-09fe01da38a4@gmx.de>
Date: Tue, 18 Jul 2017 13:07:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <HE1PR02MB10520713B65DBED2C10AEAA8BAA10@HE1PR02MB1052.eurprd02.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: Bundled libraries upgrade 'process'
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 18.07.2017 at 12:15, Anatol Belski wrote:

>> -----Original Message-----
>> From: Dan Ackroyd [mailto:danack@basereality.com]
>> Sent: Tuesday, July 18, 2017 10:42 AM
>> To: Christoph M. Becker <cmbecker69@gmx.de>
>> Cc: internals@lists.php.net
>> Subject: [PHP-DEV] Re: Bundled libraries upgrade 'process'
>>
>> On 17 July 2017 at 20:09, Christoph M. Becker <cmbecker69@gmx.de> wrote:
>>> On 17.07.2017 at 16:12, Dan Ackroyd wrote:
>>>
>>>> I just investigated an alleged bug related to the SQLite3 extension.
>>>
>>> Can you please report the bug and assign it to me.  I can't promise
>>> that I'll be able to fix it, but I would take a look.
>>
>> It's already been reported and fixed upstream.
>>
>> Reported 'bug': https://bugs.php.net/bug.php?id=74883
>>
>> Fixed in commit: https://www.sqlite.org/src/info/f27b6370407842e2
>
> Thanks for the info. The fix in mainstream doesn't look critical, as the return code is already being caught in PHP. Clear, there are explicit option checks in the linked patch, but the currently bundled Sqlite would bail out anyway. A possible improvement in the end is a different error text. The version jump seems to be big and barely justified, furthermore I'd be hesitant to bundle a just released version. Except there are some other bugs that are fixed by the newer version, I would rather go by applying the patch to the current bundled lib (if possible) or letting it go.

I agree that updating all supported PHP versions to Sqlite 3.20.0 isn't
justified here, particularly since I think this is a userland
application error – why would one create a database in read-only mode?
There wouldn't be much to read, and most likely they'd get an error for
a following `select`.

IMHO it would even be sufficient to integrate user note 121337[1] into
the docs.  At the most we could detect the erroneous flag combination
and throw an exception with a better message.

[1] <http://php.net/manual/en/sqlite3.construct.php#121337>

-- 
Christoph M. Becker