Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99837
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.220.177 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8mXNqY7Yo2f3nKQEfSbdJGSXKbgGhwzVds=bkeG_2_iQ@mail.gmail.com>
References: <CO2PR07MB569372005E8E5DC7D3426DAF9D70@CO2PR07MB569.namprd07.prod.outlook.com>
 <CAF+90c_RtVvSw5d2pWr7EGQOazeyJrdeYASiCqVmvsD6jE=H=g@mail.gmail.com>
 <a1756259-162f-3876-033f-c7aadd018710@gmail.com> <CO2PR07MB5690FDAEACAD0C46F5A416CF9D50@CO2PR07MB569.namprd07.prod.outlook.com>
 <CABdc3WqQEjbdx9Cc2DwKK2pbgShHDkwRKHJuK8j=g6d9NsChtQ@mail.gmail.com>
 <CO2PR07MB569803A8CC43A694F0614B3F9AE0@CO2PR07MB569.namprd07.prod.outlook.com>
 <CADyq6sLYd-6_titjOAtgFuCfhH8OEO6hnuPSLeoDB3rGmmijqg@mail.gmail.com> <CAF+90c8mXNqY7Yo2f3nKQEfSbdJGSXKbgGhwzVds=bkeG_2_iQ@mail.gmail.com>
Date: Tue, 11 Jul 2017 18:44:27 +0200
Message-ID: <CAEPJdu=hMq=GcD5vQnT7p7-jKJAa46NmHJ3gDF7=+ZN_07W_cA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, tyson andre <tysonandre775@hotmail.com>, 
	PHP Internals List <internals@lists.php.net>, Stanislav Malyshev <smalyshev@gmail.com>, 
	=?UTF-8?Q?Micha=C5=82_Brzuchalski?= <michal.brzuchalski@gmail.com>
Content-Type: multipart/alternative; boundary="94eb2c0812fea89c8805540d692f"
Subject: Re: [PHP-DEV] Exposing object handles to userland
From: kontakt@beberlei.de (Benjamin Eberlei)

--94eb2c0812fea89c8805540d692f
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 11, 2017 at 12:21 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Tue, Jul 11, 2017 at 11:52 AM, Marco Pivetta <ocramius@gmail.com>
> wrote:
>
> > Asking here, since it's not clear to me: is this a good/fitting
> > replacement for `spl_object_hash()`?
> >
> > On 11 Jul 2017 7:00 AM, "tyson andre" <tysonandre775@hotmail.com> wrote:
> >
> >> >> How long should I wait to see if there are objections before creating
> >> a pull request?
> >> >AFAIK you can create PR any time.
> >>
> >> I created a PR implementing spl_object_id(object $o) : int several days
> >> ago,
> >> at https://github.com/php/php-src/pull/2611
> >> --
> >> PHP Internals - PHP Runtime Development Mailing List
> >> To unsubscribe, visit: http://www.php.net/unsub.php
> >>
> >>
> Yes. spl_object_id() provides the same guarantees as spl_object_hash() --
> but is much faster and has a more compact output (an integer instead of an
> iirc 32 byte string).
>

Just to clarify, that means object ids are still re-used between objects if
one gets destroyed? The initial bug report was about creating a second
function that solves this problem.

>
> Nikita
>

--94eb2c0812fea89c8805540d692f--