Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99787
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CO2PR07MB5690FDAEACAD0C46F5A416CF9D50@CO2PR07MB569.namprd07.prod.outlook.com>
References: <CO2PR07MB569372005E8E5DC7D3426DAF9D70@CO2PR07MB569.namprd07.prod.outlook.com>
 <CAF+90c_RtVvSw5d2pWr7EGQOazeyJrdeYASiCqVmvsD6jE=H=g@mail.gmail.com>
 <a1756259-162f-3876-033f-c7aadd018710@gmail.com> <CO2PR07MB5690FDAEACAD0C46F5A416CF9D50@CO2PR07MB569.namprd07.prod.outlook.com>
Date: Thu, 6 Jul 2017 08:46:20 +0200
Message-ID: <CABdc3WqQEjbdx9Cc2DwKK2pbgShHDkwRKHJuK8j=g6d9NsChtQ@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP Internals List <internals@lists.php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary="001a11c0204c7bcccc0553a079c0"
Subject: Re: [PHP-DEV] Exposing object handles to userland
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--001a11c0204c7bcccc0553a079c0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

06.07.2017 07:24 "tyson andre" <tysonandre775@hotmail.com> napisa=C5=82(a):
>
> Updated https://github.com/TysonAndre/php-src/pull/1 , which is now much
shorter.
>
> In response to Nikita Popov's comments:
>
> > I'm +1 on the addition and would be fine with including it without RFC,
if
> > there are no objections on internals.
>
> How long should I wait to see if there are objections before creating a
pull request?

AFAIK you can create PR any time.

>
> > > - Can two objects can have the same object id
> > >   but different object handlers?
> > No: In PHP 7 this is not possible, which is also why spl_object_hash()
no
> > longer includes the handlers.
>
> True. Checking again, the implementation of spl_object_hash
> doesn't include the handlers, so I don't need to worry.
>
> > You can drop the masking. It was never effective at what it's supposed
to
> > do (hide memory addresses), but as this is the object ID only, it is
> > completely unnecessary here.
> > [...]
> > Only in the sense that it could theoretically wrap around to negative
> > numbers. Of course those would still serve as IDs just as well.
>
> That makes sense. I'm omitting the XOR
> (and returning the unobfuscated object handle/id)
> in the proposed change, then.
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

--001a11c0204c7bcccc0553a079c0--