Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99730
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.40.128 cause and error)
To: Stanislav Malyshev <smalyshev@gmail.com>, "nikita.ppv@gmail.com"
	<nikita.ppv@gmail.com>, Sara Golemon <pollita@php.net>, Bob Weinand
	<bobwei9@hotmail.com>
CC: PHP internals list <internals@lists.php.net>
Thread-Topic: [PHP-DEV] 7.2 behavior break, Bug #74836 isset on zero-prefixed
 numeric indexes in array broken
Thread-Index: AQHS9FvE9I6pqRDREESXX/e5zuff2qJDDiJE
Date: Tue, 4 Jul 2017 04:13:14 +0000
Message-ID: <BN6PR02MB323483424B088EDBD045BF50BFD70@BN6PR02MB3234.namprd02.prod.outlook.com>
References: <BN6PR02MB32341E1C5D5EE554C5C5E3EDBFD60@BN6PR02MB3234.namprd02.prod.outlook.com>,<b676fee9-9151-d13d-709c-4745c7a137a5@gmail.com>
In-Reply-To: <b676fee9-9151-d13d-709c-4745c7a137a5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BN6PR02MB323483424B088EDBD045BF50BFD70BN6PR02MB3234namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2017 04:13:14.2540
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3233
Subject: Re: [PHP-DEV] 7.2 behavior break, Bug #74836 isset on zero-prefixed
 numeric indexes in array broken
From: dmitry@zend.com (Dmitry Stogov)

--_000_BN6PR02MB323483424B088EDBD045BF50BFD70BN6PR02MB3234namp_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

Hi,


I agree with Stas and Sara.

it's easier to revert the last optimization and return to 7.1 behavior (eve=
n if it's inconsistent).

Fixing this inconsistency in PHP-Next would require RFC.


Thanks. Dmitry.




________________________________
From: Stanislav Malyshev <smalyshev@gmail.com>
Sent: Tuesday, July 4, 2017 3:23:27 AM
To: Dmitry Stogov; nikita.ppv@gmail.com; Sara Golemon; Bob Weinand
Cc: PHP internals list
Subject: Re: [PHP-DEV] 7.2 behavior break, Bug #74836 isset on zero-prefixe=
d numeric indexes in array broken

Hi!

>
> Please take a look at https://bugs.php.net/bug.php?id=3D74836
>
> What is the best option to fix this?
>
>
> The most consistent way, from my point of view - disabling zero-prefexed =
numeric strings in all cases, but this is a new behavior break.

I think this is very corner case, for string offsets. So for 7.2 to drop
support for leading-0 string, with note in UPGRADING and maybe a
notice/warning, would be ok. It is not good though that read access and
isset are not consistent, this should always work the same. It is
especially worrying that "010" and $i =3D "010" work differently, that
should never happen.

The problem is if we disable it for string offsets, it would be weird to
keep it for array offsets, and so for arrays "010" should be treated as
string I guess? Which may involve more breakage. So I wonder if a better
way would be to just let it be as it always was, and maybe make
leading-0 strings not to be interpreted as numbers for both cases in
PHP.next when we can do BC breaks.

--
Stas Malyshev
smalyshev@gmail.com

--_000_BN6PR02MB323483424B088EDBD045BF50BFD70BN6PR02MB3234namp_--