Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99729
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
To: Dmitry Stogov <dmitry@zend.com>,
 "nikita.ppv@gmail.com" <nikita.ppv@gmail.com>, Sara Golemon
 <pollita@php.net>, Bob Weinand <bobwei9@hotmail.com>
Cc: PHP internals list <internals@lists.php.net>
References: <BN6PR02MB32341E1C5D5EE554C5C5E3EDBFD60@BN6PR02MB3234.namprd02.prod.outlook.com>
Message-ID: <b676fee9-9151-d13d-709c-4745c7a137a5@gmail.com>
Date: Mon, 3 Jul 2017 17:23:27 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0)
 Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <BN6PR02MB32341E1C5D5EE554C5C5E3EDBFD60@BN6PR02MB3234.namprd02.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 7.2 behavior break, Bug #74836 isset on zero-prefixed
 numeric indexes in array broken
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> 
> Please take a look at https://bugs.php.net/bug.php?id=74836
> 
> What is the best option to fix this?
> 
> 
> The most consistent way, from my point of view - disabling zero-prefexed numeric strings in all cases, but this is a new behavior break.

I think this is very corner case, for string offsets. So for 7.2 to drop
support for leading-0 string, with note in UPGRADING and maybe a
notice/warning, would be ok. It is not good though that read access and
isset are not consistent, this should always work the same. It is
especially worrying that "010" and $i = "010" work differently, that
should never happen.

The problem is if we disable it for string offsets, it would be weird to
keep it for array offsets, and so for arrays "010" should be treated as
string I guess? Which may involve more breakage. So I wonder if a better
way would be to just let it be as it always was, and maybe make
leading-0 strings not to be interpreted as numbers for both cases in
PHP.next when we can do BC breaks.

-- 
Stas Malyshev
smalyshev@gmail.com