Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99725
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain heigl.org designates 195.191.240.18 as permitted sender)
To: Andreas Treichel <gmblar@gmail.com>, internals@lists.php.net,
 =?UTF-8?Q?C=c3=b4me_Chilliet?= <come@opensides.be>
References: <2963553.WttLOBJENj@mcmic-probook>
 <D9.81.15131.6EC5A595@pb1.pair.com>
Openpgp: id=967CCFA50DFFEE03BB8BF5F2CA9213C75BFCE472
Message-ID: <9a0b9d93-a8bd-0da0-dc16-971eb5d0c448@heigl.org>
Date: Mon, 3 Jul 2017 23:21:15 +0200
MIME-Version: 1.0
In-Reply-To: <D9.81.15131.6EC5A595@pb1.pair.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="kSs04vj8CjBdUEhxlJWb3De4FqiK5TSab"
Subject: Re: [PHP-DEV] Re: [RFC] LDAP EXOP
From: andreas@heigl.org (Andreas Heigl)

--kSs04vj8CjBdUEhxlJWb3De4FqiK5TSab
Content-Type: multipart/mixed; boundary="gaFBBwrFBUnmkplEBO71Vc2CGid5RRJX1";
 protected-headers="v1"
From: Andreas Heigl <andreas@heigl.org>
To: Andreas Treichel <gmblar@gmail.com>, internals@lists.php.net,
 =?UTF-8?Q?C=c3=b4me_Chilliet?= <come@opensides.be>
Message-ID: <9a0b9d93-a8bd-0da0-dc16-971eb5d0c448@heigl.org>
Subject: Re: [PHP-DEV] Re: [RFC] LDAP EXOP
References: <2963553.WttLOBJENj@mcmic-probook>
 <D9.81.15131.6EC5A595@pb1.pair.com>
In-Reply-To: <D9.81.15131.6EC5A595@pb1.pair.com>

--gaFBBwrFBUnmkplEBO71Vc2CGid5RRJX1
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hey C=C3=B4me, hey Andreas.

Am 03.07.17 um 17:04 schrieb Andreas Treichel:
> Hello,
>=20
> please change the signature form
>=20
> bool ldap_exop_whoami(resource $link, string &$result)
>=20
> to
>=20
> string ldap_whoami(resource $link);
>=20
> i dont see the benefit to return a single value with a reference.
>=20
> Without a reference the function can used as an argument:
> doSomethingWithTheUserName(ldap_whoami($link));
>=20
>=20
> With a reference a variable is required:
> ldap_whoami($link, $username);
> doSomethingWithTheUserName($username);
>=20
>=20
> same with the return statement of a method:
>=20
> class MyLdap
> {
>     public function getCurrentUser(): string
>     {
>         return ldap_whoami($this->link);
>     }
> }
>=20
> class MyLdap
> {
>     function getCurrentUser(): string
>     {
>         ldap_whoami($this->link, $username);
>         return $username;
>     }
> }

After thinking a while about this I think it would be a good idea to
alter the signature of the functions and return a value or FALSE instead
of a boolean value.

In my eyes the code and the extension would benefit in a few ways:

* It would allow us to slowly get rid of pass-by-reference variables
* It would make it easier for users to get a value
* It would allow us to shift to use Exceptions instead of errors more eas=
ily

For methods that could return more than one value we could return an
array or an object.

There are currently both ways in the code but from the discussions I've
had so far I've learned that removing the references (and getting rid of
the resources) would be a plus.

=46rom what I've seen in the code at least removing the pass-by-reference=

should be possible without too much changes.

So the signatures would look like this:

string|FALSE ldap_exop_whoami(resource $link) - The returned string is
the DN of the currently bound user.

string|FALSE ldap_exop_passwd(resource $link [, string $user [, string
$oldPassword [, string $newPassword]]] - The returned string is the new
password of the user. Either the given newPassword or a newly generated o=
ne.

Both would return FALSE on an error (or throw an Exception) so one can
use them like this

if (false =3D=3D=3D ($password =3D ldap_exop_passwd($link))) {
    // something went wrong
} else {
    echo $password;
}

Or is that complete and utter nonsense?



Cheers

Andreas

--=20
                                                              ,,,
                                                             (o o)
+---------------------------------------------------------ooO-(_)-Ooo-+
| Andreas Heigl                                                       |
| mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=B0=
23'58" |
| http://andreas.heigl.org                       http://hei.gl/wiFKy7 |
+---------------------------------------------------------------------+
| http://hei.gl/root-ca                                               |
+---------------------------------------------------------------------+


--gaFBBwrFBUnmkplEBO71Vc2CGid5RRJX1--

--kSs04vj8CjBdUEhxlJWb3De4FqiK5TSab
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEENHMr85T+FLwCJRBgjNqPc6i4Q/AFAllatUsACgkQjNqPc6i4
Q/BXixAAsqNbWjIH5rKheiK+tXNwa2bMx30zJmXANFWPnfZXvch9ZS/c1qzULy9h
jKkGyStX200TI05syqzcy2H4+Bwwunrf82dbNIZg6rx/jDzB11rHML9VXPsXLhGo
GDzKYf5hUYj5wxImU7R+/eHZLjTvtTXaNPrGdWA1BWzxzECtTq2udSY4nl06o+Fm
56Tua4mA0AaLx5SZdCPyzxnz20DoQYIOzJDBDgVfDDfzUsfqmQ9Qmv7fsJt3fhwV
Xktsthyfxp3dBQmjaOfiSKU9AxfGAnJSzPSKr1o8gAJPsTrkqXW2gKNGGRZMJsV6
gjpseM5tkIUwbIAvf+eazhy7JXwxb1BBr/u+r6VguluJ8XohrPHjW7OV0/u64dRA
bcHVlO6+vcT6AbYjRqQk+hCtXh2Xbl54+1BGVcdIzvmx03WXhNiXt5sPcG1//tLa
4STwJOFvAj5nW4S33vRX0x4o+n2ERsEVVBKZWE+hqMdVvSDGJigl0UeogAsMpl00
eCmj0UCjJFQRK7lrAR+PEWHHIZFeVmkbdeiy6MlDewPKX9d7/ZSsavyo5IoLEmCz
/9aaWVQb05IB44fUWddRZk0S2hsgsaPbatoHcZ2KqdsNvYEsqU7fysKZxCkP1PSN
uHNG6whLFqY/Ret13/VjmMQ1GH3BRtkZxdyDorqQkO+pGRhLk2Y=
=/Egs
-----END PGP SIGNATURE-----

--kSs04vj8CjBdUEhxlJWb3De4FqiK5TSab--