Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99711
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain dqxtech.net from 209.85.223.182 cause and error)
MIME-Version: 1.0
In-Reply-To: <CANUQDCi14z+++0+vLpEM6EV3DuTtv4FnmOjJMjKCNJbzj6fL+Q@mail.gmail.com>
References: <CAH0Uv3Gx_OGBA4zwzE97mbK_VtwBtRCX3yn9JNv81VWtQbCYtA@mail.gmail.com>
 <CAESVnVoQ-+mbUiXAUO1tsRzAqSGJnOnxba9qe=HAU-kqCyYTng@mail.gmail.com>
 <CAH0Uv3EdyPRgcYXuFP5GVjPpx4+kga_HbE9zzbu1XsAVSMjJ-w@mail.gmail.com> <CANUQDCi14z+++0+vLpEM6EV3DuTtv4FnmOjJMjKCNJbzj6fL+Q@mail.gmail.com>
Date: Mon, 3 Jul 2017 17:50:30 +0200
Message-ID: <CAH0Uv3Hy-q7h=LZ9GNvHAPJZ_0tLWVDvVeas8RRSTbvqUdQfaw@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] "Reader" as alternative to Iterator
From: andreas@dqxtech.net (Andreas Hennings)

On Mon, Jul 3, 2017 at 9:09 AM, Niklas Keller <me@kelunik.com> wrote:
>
> Hey Andreas,
>
> what you're trying to do here seems to be premature optimization. While you
> save a bunch of method calls, your I/O will be the actual bottleneck there.
> It's entirely fine to implement such logic in userland.

I will let this stand unchallenged, until I have some reproducible data..

>
> Amp has a similar interface for its streams, but those have only string|null
> as types. If you want to allow all values, you either need a second method
> or need to wrap all values in an object.
>
> http://amphp.org/byte-stream/#inputstream +
> http://amphp.org/amp/iterators/#iterator-consumption

This library looks interesting.
It seems to do a lot more than I currently need, with its concurrency approach.
I am a bit puzzled by the yield keyword in this code:

 while (($chunk = yield $inputStream->read()) !== null) {
    $buffer .= $chunk;
}

In my experience with generators so far, you either use yield for
sending or for receiving. So either "yield $value;" or "$value =
yield;" In this case it seems to do both.
I assume this is to achieve the concurrency.

(This is not an argument for or against anything, just an observation)