Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99709
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender)
To: internals@lists.php.net
Date: Mon, 03 Jul 2017 17:41:41 +0200
Message-ID: <22047139.crhYHZD0IP@mcmic-probook>
Organization: OpenSides
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <D9.81.15131.6EC5A595@pb1.pair.com>
References: <2963553.WttLOBJENj@mcmic-probook> <D9.81.15131.6EC5A595@pb1.pair.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2030150.tvuyc5jthi"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Subject: Re: [PHP-DEV] Re: [RFC] LDAP EXOP
From: come@opensides.be (=?ISO-8859-1?Q?C=F4me?= Chilliet)

--nextPart2030150.tvuyc5jthi
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Le lundi 3 juillet 2017, 17:04:02 Andreas Treichel a =C3=A9crit :
> i dont see the benefit to return a single value with a reference.
>=20
> Without a reference the function can used as an argument:
> doSomethingWithTheUserName(ldap_whoami($link));

Where do you handle errors in this case?

For me returning a mixed will result in:
$identity =3D ldap_exop_whoami($link);
if ($identity !=3D=3D FALSE) {
=09// do something with $identity
} else {
=09// handle errors
}

While with the reference it=E2=80=99s cleaner:
if (ldap_exop_whoami($link, $identity)) {
=09// do something with $identity
} else {
=09// handle errors
}

It seems both solutions exists in existing LDAP methods:
https://secure.php.net/manual/en/function.ldap-get-option.php
https://secure.php.net/manual/en/function.ldap-get-dn.php

The other thing I liked about using bool return and a reference is that=
 it will allow all ldap_exop_* methods to be consistent, all returning =
a boolean and filling as many reference parameters as needed (from 0 to=
 whatever).

> same with the return statement of a method:
>=20
> class MyLdap
> {
>      public function getCurrentUser(): string
>      {
>          return ldap_whoami($this->link);
>      }
> }
>=20
> class MyLdap
> {
>      function getCurrentUser(): string
>      {
>          ldap_whoami($this->link, $username);
>          return $username;
>      }
> }

This is a valid point.

C=C3=B4me
--nextPart2030150.tvuyc5jthi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZWmW5AAoJEKhk2MPOyw4AE+MP/2SdXGjrTGmlYMDOCtC6EsQg
NOQuI3VKQRA/TPYMTvPXL6vusG//LMcJcbiVkI4hIUg5IR2xg4Q4RF1l2oMYLZtR
bMHHgJeBroXk2E9lzac3/XRuGNFYuiVIQAQPXpU2z7zW9P9oS0pQHg+q7n08CvSJ
ZsLw996Kmxv4Ly7XtXNTzk44ghlNnqclgOmYZlynScAM8p6c9GgDXi9eZ1FHJejK
xNaMaWwEMAI3potZgaMlDUwkKuPf50S/zpUmAQD7YSWX/2+krEOcUNSNnCADCmsk
Xoq0UXnGPRD5jwMlsnWC63aA6683HqTbMwayuHl5PT3yP76r4MdrW3T1/l1iJnxZ
RwQM4N/89Iv2t+a/caQpdtHABK9b/ehql3Gs5CUQCPdF8ea3sV6SdGvyiN3HQgk0
UzrM/Q7L7vLz0aH62d32whJNbu366+86VxLpwvAMoGA750caLpHCemp/yFJaG4NT
3gN0RiWyBvV92GI2PlsWPmsGNJ03REHqYfoEiw+xJZP2kWrySm+r4v4jq+CUySux
Q581SHqFUX7FEi+dmc1e4ju5QWmjEOTm/wt84j04ntL7PxF36nL2I4booxQjW8qz
PCV8klGMK4SuMcDHKXfUZL1lJ4r7L321as76FB9tR97EGr4T3KuXxXZ3tPhA3Pxs
iEhy9jo7oo8j8X5Tpzin
=X3be
-----END PGP SIGNATURE-----

--nextPart2030150.tvuyc5jthi--