Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99703 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32686 invoked from network); 3 Jul 2017 14:06:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2017 14:06:33 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.48 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 74.125.82.48 mail-wm0-f48.google.com Received: from [74.125.82.48] ([74.125.82.48:35961] helo=mail-wm0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B3/21-15131-76F4A595 for ; Mon, 03 Jul 2017 10:06:32 -0400 Received: by mail-wm0-f48.google.com with SMTP id 62so170087343wmw.1 for ; Mon, 03 Jul 2017 07:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0/a+vExpuWR8TRmYhP71TUwiX1hjug97IAj46Zpl0WE=; b=J93LBpx3pNUj3ass/jnLMLmkywcW2/pw6hDxP3/tqNbqTkoGHVrP8DUFUJLbUk826u wzrmRzYetEsc/AkfoxvVJjn/AmbORBaWyGF5ZALoeI8IfbDviOxbH9PFwMyHyRJQA+XN qFVQwR0wyMi/ZczD0bUMv/h8QSgduM3jCkG6AKF1imY9T5b2gOn5nS36DcLFMVHUusfI eVMNC2DR3zk6i3eb656DZZqBl1QLpu5z0aJte0EyFfUMvCYyAy03E2FENMZHTjygSfIR SVoXlCktQpwdfuQpJfXy938w0TvXeim0R/mUhV6OT83or6i2OZRsggh1EevvQFpVmP5Q T+KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0/a+vExpuWR8TRmYhP71TUwiX1hjug97IAj46Zpl0WE=; b=Cz3TtaOje0AKLUKR4hHOBpp/gA7kl42q2dLtKci+rv9ZYmUO+arHQ5B3RbXQh5Pck3 ExCbtPWtqOzeEQVWaQxqAFIq+MYNyvWtAd6ztWk96BaddfVfMmNSdvZw7KAyn3OZK1rP 8DyruLS0fa2VyjPHEpjkVGC+1aqGeRjfyp8CQ26rkWa5ZMFGxE9e5H4yjEbkmPBSeeMe 3HIqQjDB91VnFbcuMjFGEG9Elha3KWzuglkaHtsnSL+G28ea2zHv4+CvTt7Q6TOY/u6K p1rWDJQi/IdySsgvmTEHqMoK2PrUMeQxt2eYsffGYKWweGGTbPl1bzgxorOs9vfoPBu4 B6fg== X-Gm-Message-State: AIVw112IQ0w974qspkyT+yC0OrBmmUvoYUFsDWYfGK/QlEqJ9IMaSbJT ETPt8S7PIjCgjqogEQClgDXD59uk0Kx2 X-Received: by 10.28.55.201 with SMTP id e192mr14274101wma.75.1499090788571; Mon, 03 Jul 2017 07:06:28 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.223.169.139 with HTTP; Mon, 3 Jul 2017 07:06:28 -0700 (PDT) X-Originating-IP: [71.251.16.204] In-Reply-To: References: Date: Mon, 3 Jul 2017 10:06:28 -0400 X-Google-Sender-Auth: eurwsDHjGIJbfjtFTcfgAYOsb1A Message-ID: To: Dmitry Stogov Cc: "nikita.ppv@gmail.com" , Bob Weinand , PHP internals list Content-Type: text/plain; charset="UTF-8" Subject: Re: 7.2 behavior break, Bug #74836 isset on zero-prefixed numeric indexes in array broken From: pollita@php.net (Sara Golemon) On Mon, Jul 3, 2017 at 3:03 AM, Dmitry Stogov wrote: > Please take a look at https://bugs.php.net/bug.php?id=74836 > > What is the best option to fix this? > I'm more curious *why* we throw out numeric strings starting with zeros in _zend_handle_numeric_str_ex() But since the answer to that question probably lies down a long road to even worse BC-breaksville, how about we revert your IS_CONST optimization for 7.2 and give it the time it needs for 7.3? -Sara