Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BN6PR02MB3234B7DF1CB838B3CD0F70BEBFDB0@BN6PR02MB3234.namprd02.prod.outlook.com>
References: <BN6PR02MB3234B7DF1CB838B3CD0F70BEBFDB0@BN6PR02MB3234.namprd02.prod.outlook.com>
Date: Fri, 23 Jun 2017 11:48:15 +0800
Message-ID: <CABBJUpeJDAPBu9CqN2A4zuL38eFfhx1=zvPP=Nfgkmc3YYR8=Q@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: "nikita.ppv@gmail.com" <nikita.ppv@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, 
	PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a114a7426d761aa055298794c"
Subject: Re: Request shutdown optimization
From: laruence@gmail.com (Xinchen Hui)

--001a114a7426d761aa055298794c
Content-Type: text/plain; charset="UTF-8"

Hey:

On Thu, Jun 22, 2017 at 3:29 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> hi,
>
>
> could you, please, review the PR https://github.com/php/php-src/pull/2591
>
>
> The main idea is not to free request-allocated zvals, because they are
> freed by Zend MM anyway.
>
> Also, shutdown_executor() code was simplified by calling destructors and
> closing resources, before freeing data.
>
>
> all tests are passed.
>
I don't see any problems,

(just one concern, fast_shutdown is only enable in non-debug mode, which
may cause troubles for debuging fast_shutdown problems, maybe we could
 change it to :

 fast_shutdown =
 #if ZEND_DEBUG
            !report_memleaks &&
#endif
           is_zend_mm && !full_table_clean;
),

anyway, this feature is already exists in opcache for quite a long time, so
I think could commit it.


thanks

>
> Thanks. Dmitry.
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a114a7426d761aa055298794c--