Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99605 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45149 invoked from network); 22 Jun 2017 07:29:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jun 2017 07:29:43 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.34.123 cause and error) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 104.47.34.123 mail-by2nam01on0123.outbound.protection.outlook.com Received: from [104.47.34.123] ([104.47.34.123:23098] helo=NAM01-BY2-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/60-40687-4E17B495 for ; Thu, 22 Jun 2017 03:29:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RWSoftware.onmicrosoft.com; s=selector1-zend-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nU21R0aWtyR1KjIYgTkOyMgFcmYqxPYN4easpGgStY8=; b=h2zimGSaxKyBg3NPAz+UWVeiUGyHW94HRN5Y0YgYX4MvB6EwN1ZmblnchzpdfwsMrBan1r59tJ8c6N4ehvUNNb1xumqcWsYY/MMjur863YFk28W31wgmhecyOrlZK/98opAOgXfE7Pj2h7N5DCISRRzKqmFm4dvH1Fq2FM9T2YM= Received: from BN6PR02MB3234.namprd02.prod.outlook.com (10.161.152.32) by BN6PR02MB3233.namprd02.prod.outlook.com (10.161.152.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Thu, 22 Jun 2017 07:29:36 +0000 Received: from BN6PR02MB3234.namprd02.prod.outlook.com ([10.161.152.32]) by BN6PR02MB3234.namprd02.prod.outlook.com ([10.161.152.32]) with mapi id 15.01.1178.023; Thu, 22 Jun 2017 07:29:36 +0000 To: "nikita.ppv@gmail.com" , Xinchen Hui , Bob Weinand CC: PHP internals list Thread-Topic: Request shutdown optimization Thread-Index: AQHS6yiMOE4Y6pXXik6goQGjd7A9aQ== Date: Thu, 22 Jun 2017 07:29:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.php.net; dkim=none (message not signed) header.d=none;lists.php.net; dmarc=none action=none header.from=zend.com; x-originating-ip: [213.21.45.232] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR02MB3233;7:IfnJ5DSxx6pMlLwlBdc8NWPFXbScduf4V/2Vbz6qHYHVS/Gh+rboFKnx3rdCibT9G1pssm2oYRYhBAGdcQ+C1ZbuTEw3lorETOWFV8eUto7NPfBRJVyzZup2J4TFoMcPH0XEbUg7QGDRZ61YYfCSgDHe/JcvL+xLf7BCXbrUO1FBCtGbVKMtC+AL0DSesekbloaN/WeXykmSzEd0Oxa/JA/T8/eYSnZFE+AMcRDTEKUg1G1sGdSnXzWKvniP1QbOWvJIUXDDC+sGBd42TtS0ktHQxJjqCyQZzNSr5YairTHrYEM1rTH9f5gSP1BqjiEAjCQmq3iMh1+T3mUu6jAJFixDOLz2CmaXUwYfJtfsP4In39JevRsh7OQHP0l6ijhtbGRfx7OYOMgw015dRfRpc5tTPKk5ACqJAujt9yVLH3coEpnYBtFgqudnMFijL+CXdeE+aLLz8lFgXpJox8mGWdqQoxRMxL+2uMT48iCQmx1VI/QSBXVVDp7g6hsZdiz3W4uemWoslrgK9UywJhjHYnuwNsgYWwc+z8seLFXkhJvtHDIWDPc3Bi8LdsCOrCLHHhx8m3RKlR2ndaa5f8drGwyVqKSOQlf3HcFqpxifyDwvwPBxO1oRHJyn57iRCJP3DHO8Z3k0lUD8IiIrPC044nJ3tP12pnVqzRfOUnujsPn6S/c/SzeOjVnnxynJJ1KwmTvFNsLiphZfkbhPAsKmxE6dyZLdVI4B8I4jDk7VgDP9UXlX5A/MfUmYed903ysN0Uy8kDKTt+x2g8n5GKyAwK7mZqqvKI4BIGX85tD5DZ4= x-ms-office365-filtering-correlation-id: c19d5406-cabb-49b8-ea25-08d4b9406f2a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:BN6PR02MB3233; x-ms-traffictypediagnostic: BN6PR02MB3233: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR02MB3233;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR02MB3233; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39410400002)(39400400002)(39840400002)(39450400003)(6506006)(5660300001)(966005)(7696004)(25786009)(3846002)(6116002)(4326008)(102836003)(53936002)(478600001)(66066001)(74316002)(77096006)(86362001)(7906003)(14454004)(2906002)(122556002)(39060400002)(2501003)(3280700002)(2900100001)(8676002)(189998001)(6606003)(3660700001)(9686003)(7116003)(54896002)(99286003)(55016002)(7736002)(8936002)(236005)(19627405001)(606005)(6436002)(3480700004)(54356999)(38730400002)(50986999)(33656002)(81166006)(6306002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR02MB3233;H:BN6PR02MB3234.namprd02.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_BN6PR02MB3234B7DF1CB838B3CD0F70BEBFDB0BN6PR02MB3234namp_" MIME-Version: 1.0 X-OriginatorOrg: zend.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2017 07:29:35.9240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3233 Subject: Request shutdown optimization From: dmitry@zend.com (Dmitry Stogov) --_000_BN6PR02MB3234B7DF1CB838B3CD0F70BEBFDB0BN6PR02MB3234namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable hi, could you, please, review the PR https://github.com/php/php-src/pull/2591 The main idea is not to free request-allocated zvals, because they are free= d by Zend MM anyway. Also, shutdown_executor() code was simplified by calling destructors and cl= osing resources, before freeing data. all tests are passed. Thanks. Dmitry. --_000_BN6PR02MB3234B7DF1CB838B3CD0F70BEBFDB0BN6PR02MB3234namp_--