Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99582 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35066 invoked from network); 21 Jun 2017 02:45:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jun 2017 02:45:12 -0000 Received: from [127.0.0.1] ([127.0.0.1:15338]) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ECSTREAM id 78/D7-13828-8BDD9495 for ; Tue, 20 Jun 2017 22:45:12 -0400 Authentication-Results: pb1.pair.com smtp.mail=idealities@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=idealities@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.175 as permitted sender) X-PHP-List-Original-Sender: idealities@gmail.com X-Host-Fingerprint: 209.85.217.175 mail-ua0-f175.google.com Received: from [209.85.217.175] ([209.85.217.175:35060] helo=mail-ua0-f175.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 05/D7-13828-61BD9495 for ; Tue, 20 Jun 2017 22:33:59 -0400 Received: by mail-ua0-f175.google.com with SMTP id j53so85711200uaa.2 for ; Tue, 20 Jun 2017 19:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=NNBrhtbYtOBT+nSIqwHwLlHv4mrdUmxIMTpNTwyc2Oo=; b=i7CNwiMOoi770QVIzmsFQd9cZFkrz0FLDybIPRNcoFa4UimRnCzp7BHGrWl50432xI Y21UwuOfM3OhbkTQ4JZncStXo7SLZ9x1brRWpMckkQ8GWrBTJ+rbExyvJ9Jy4rgpkXIL olZd/cLGD/Ig1V3ZCykdKcYnPq7Vr8rBbjvTqYytWc0fQN+0yijmtTkF65xJBdPA5W4D BjBLo1qDLPFFbN9OCMeoOjDgbAWtEvjWWfY/XSdvG5xF7LEgbMw2Y0qkcb5thNhUCTiy RM1MgvM4mlYfA4S4AS2nR1mVfy1naRuQXBiwARwC4uVtPxOI/iA522dK//VubYTMZfAG 6HQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NNBrhtbYtOBT+nSIqwHwLlHv4mrdUmxIMTpNTwyc2Oo=; b=GdlgPOMmWzrg9HOE+EKte61wVe4tr1rQA1uWhKilAFhCtNGuYoXL4B4IlF3xNDRh62 aNDnSIrhEIr2zmZiwnAiIiBtlndE/w16zanns4H/38Rp4meMWCpb3t+CT8pmdpHnQzjm AAq4WMrM9relYLygj07OnJBZJIXwsYhtkIx0GkfzQDmAiPE8ZXejBCTw997R5lWeN4jf xTQ9M1txMTnJotyTZ7vB4HgavaMysA8XoNQ3Zamot+iRxpUvjTdXbYFwn8J5DTk0W1Bo AiofHmNH96kpOi0Q/Fht/+J/b/OdEkbtkSpxw0z8ImXxM7uY6wc+UZ/SWUo+7hOWoLOA 5gkg== X-Gm-Message-State: AKS2vOzPFf3eEG5kCXDrAgNPe4AnNTTeS7Bc2WAZvTbzwNDaWzwD9oRZ QVZGc3b/zHEUtEDQW2nLB7V3/ZkBTIMG X-Received: by 10.176.79.227 with SMTP id t35mr21347972uah.5.1498012435765; Tue, 20 Jun 2017 19:33:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.222 with HTTP; Tue, 20 Jun 2017 19:33:55 -0700 (PDT) Date: Wed, 21 Jun 2017 10:33:55 +0800 Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary="f403043643861a603305526f3303" Subject: Error of codes on page https://wiki.php.net/phpng-upgrading From: idealities@gmail.com (ideal) --f403043643861a603305526f3303 Content-Type: text/plain; charset="UTF-8" Hi, The codes that show usage of smart_string: - smart_str str = {0}; - smart_str_appendl(str, " ", sizeof(" ") - 1); - smart_str_0(str); - RETURN_STRINGL(implstr.c, implstr.len, 0); + smart_string str = {0}; + smart_string_appendl(str, " ", sizeof(" ") - 1); + smart_string_0(str); + RETVAL_STRINGL(str.c, str.len); + smart_string_free(&str); Maybe actually should be: - smart_str str = {0}; - smart_str_appendl(str, " ", sizeof(" ") - 1); - smart_str_0(str); - RETURN_STRINGL(implstr.c, implstr.len, 0); + smart_string str = {0}; + smart_string_appendl(&str, " ", sizeof(" ") - 1); + smart_string_0(&str); + RETVAL_STRINGL(str.c, str.len); + smart_string_free(&str); Thanks. --f403043643861a603305526f3303--