Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99572
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.44 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <a07aba93-5e75-384a-0b35-6972463d8c18@tekwire.net>
References: <c4017446-f784-2861-443a-53a2f47838bf@free.fr> <6f24a712-4742-b2e0-81d3-821c817b619c@free.fr>
 <cd4ec791-fe18-3049-fb71-b332cd6eecb5@tekwire.net> <CAESVnVocft25oYTz0wS7KMbz95yor64SMj8DPdOE1j2bEhVAxw@mail.gmail.com>
 <a07aba93-5e75-384a-0b35-6972463d8c18@tekwire.net>
Date: Tue, 20 Jun 2017 09:30:29 -0400
Message-ID: <CAESVnVrOT_oJTN6hOcG31HeE6dJy4t-4nT=pwsjzcqRJaAySeQ@mail.gmail.com>
To: =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@tekwire.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC][VOTE] Allow loading extensions by name
From: pollita@php.net (Sara Golemon)

I'll double check later today, it might be that this comes in from the
startup phase and we can't do zend_error() for some reason.  Either
way I'll get it merged soonish.
Thanks.
-Sara

On Tue, Jun 20, 2017 at 6:53 AM, Fran=C3=A7ois Laupretre
<francois@tekwire.net> wrote:
> Hi Sara,
>
> Le 19/06/2017 =C3=A0 23:33, Sara Golemon a =C3=A9crit :
>>
>> I was about to merge this, but ran into some issues (mostly minor).
>> Could you at least address the fwrite(stderr, ...) item (and
>> preferably clean up the style nits while you're at it)?
>>
>> Oh, and I forgot to include it in the CR, but there are some
>> tabs/spaces issues as well.
>
> I fixed typos and style issues.
>
> About the 'fwrite(stderr,', I just used the same mechanism used by
> zend_load_extension() to raise an error. If you consider it is safe to
> replace it with a call to zend_error(), I'll do it.
>
> Regards
>
> Fran=C3=A7ois