Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99571 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68435 invoked from network); 20 Jun 2017 10:54:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jun 2017 10:54:02 -0000 Authentication-Results: pb1.pair.com header.from=francois@tekwire.net; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=francois@tekwire.net; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain tekwire.net does not designate 212.27.42.4 as permitted sender) X-PHP-List-Original-Sender: francois@tekwire.net X-Host-Fingerprint: 212.27.42.4 smtp4-g21.free.fr Received: from [212.27.42.4] ([212.27.42.4:42588] helo=smtp4-g21.free.fr) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FC/01-13828-9CEF8495 for ; Tue, 20 Jun 2017 06:54:02 -0400 Received: from [172.16.0.26] (unknown [158.255.108.131]) (Authenticated sender: flaupretre@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 157D819F46A; Tue, 20 Jun 2017 12:53:55 +0200 (CEST) To: Sara Golemon Cc: PHP internals References: <6f24a712-4742-b2e0-81d3-821c817b619c@free.fr> Message-ID: Date: Tue, 20 Jun 2017 12:53:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr Subject: Re: [PHP-DEV] [RFC][VOTE] Allow loading extensions by name From: francois@tekwire.net (=?UTF-8?Q?Fran=c3=a7ois_Laupretre?=) Hi Sara, Le 19/06/2017 à 23:33, Sara Golemon a écrit : > I was about to merge this, but ran into some issues (mostly minor). > Could you at least address the fwrite(stderr, ...) item (and > preferably clean up the style nits while you're at it)? > > Oh, and I forgot to include it in the CR, but there are some > tabs/spaces issues as well. I fixed typos and style issues. About the 'fwrite(stderr,', I just used the same mechanism used by zend_load_extension() to raise an error. If you consider it is safe to replace it with a call to zend_error(), I'll do it. Regards François