Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99549
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALYT1YrCb_tLmj2hQZNnkPD-MbhdfRBYnWPyMsKv-A8c36-EMg@mail.gmail.com>
References: <CALYT1YrCb_tLmj2hQZNnkPD-MbhdfRBYnWPyMsKv-A8c36-EMg@mail.gmail.com>
Date: Mon, 19 Jun 2017 09:40:31 -0500
Message-ID: <CALrkBjbBQeRVzxkrVrXz281+CJd3VxTwAmwpwVesb6EntgV8kA@mail.gmail.com>
To: Sammy Kaye Powers <me@sammyk.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a11406370ee10050552511d4b"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Retry functionality
From: pencap@gmail.com (Mike Willbanks)

--001a11406370ee10050552511d4b
Content-Type: text/plain; charset="UTF-8"

>
> Hello internals!
>
> The RFC that proposes adding retry functionality to the
> `try/catch/finally` block is now officially "under discussion".
>

This feature seems like something that would be extremely useful.  However,
the proposed syntax for the number of retries for a block level seems to
get me.  I think what might actually be better from a functional standpoint
is:

try {
  doSomething()
} catch (SomethingException $e) {
  retry 3;
} catch (RetryMaximumExceeded $e) {
  $e->getOriginatingException();
}

Forcing retry to only work on the keyword level and then providing a
distinct exception when the retry has been exceeded.  The issue obviously
with the above is that you would need to be able to add the originating
exception to it rather than bubbling up.  What I like more about this, is
that it makes it far more clear as per the rejected path and allows you to
determine that you had to throw since the retries failed so many times.
Often in many applications, you might retry a couple of times and then
defer that action to be handled in the background at a later time.  In
addition, you may also still want to handle that exception to check certain
criteria around the failure.  For instance, it is often that libraries
reuse the same exception but providing different codes and/or messages that
you may want to check to see if it is retryable or add additional meta data
to the response.

I also think that the RFC should state that retry keyword MUST be used with
a numeric number to prevent continuous loops.  Eventually all loops must
die and preventing this early on seems to be something that would be a good
idea to handle.


>
> https://wiki.php.net/rfc/retry-keyword
>
> Voting will open on Monday, July 3rd, 2017 @ 9 am CDT.
>
> Voting will close on Monday, July 17th, 2017 @ 9 am CDT.
>
> Discuss amongst yourselves. :)
>
> Thanks,
> Sammy Kaye Powers
> sammyk.me
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a11406370ee10050552511d4b--