Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99544 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72257 invoked from network); 19 Jun 2017 12:31:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2017 12:31:12 -0000 Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.161.170 mail-yw0-f170.google.com Received: from [209.85.161.170] ([209.85.161.170:33413] helo=mail-yw0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 91/35-13828-D04C7495 for ; Mon, 19 Jun 2017 08:31:10 -0400 Received: by mail-yw0-f170.google.com with SMTP id 63so39750874ywr.0 for ; Mon, 19 Jun 2017 05:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=O8lSEm6BqAqnqDr/kWDYX/kc4K84OloHZAeNuhHSzAU=; b=NEdvGfT1ZzTtHRoPopcjlTKa6OMl+kzwuJzk17GjiNaFI0EeirZu5fCxiyucLb9hy9 PQ3QfYOeLfPGS/epWkpxEfmif5MTMBr7xZr4Mqp/kxxJWF0/0kg9eBIhZoZObcUAigqh o3WH1rO2gh94VmyfogSrs2+suM9mD2b+BvxJp6xzM7JLratN+Lv7oLkhoJ0r8veDQC9j jwwg276yzZ5wCqvBK9U6bg7P1eZ+RVQGk/ce2L3J4KDuFexxm/5R8mHC3KCDqxA4Mqkt rHsa/W+Piwt3Xd1tajJb1u2j1Ijy94YnliLneRGXARR9YuXQaBjj0cjZLLQ2r5NbOZQN MRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=O8lSEm6BqAqnqDr/kWDYX/kc4K84OloHZAeNuhHSzAU=; b=hTAv09ckaJgeSPW2hTFFBkwEFYPv3lZ5lnmMlch8R0RCf74UtO5D+rTRhGMPRy+p81 xOhf5OrQcQYBTb7jdViFtJz6toyeBxL6q3gkqZRMmgBQjCDSCHosPLxUrRx4nApNR8PC +pm5rwqZd2oJVm4Gq5d84oeFyycGzzAqXcGIlxMSLgfCR4TIsWnC1q1+kQlBJ5kLjOT6 eH5OBlAChF99o8FkYNmBIxJITDNb0NQ6qIuK2gVsWJKgWrQIMKMIee3YpF4zSCOuN1Qn bBZLWk54VV3UrLXyqImlidZuO3owsK7WFVNlJcUe/SgHqIcNgcHrk3ANkrntV/3yK9Qt jn2A== X-Gm-Message-State: AKS2vOxuszqre3kX5dcfm44eW8P0uNapqIt6ZeS6/nvLKDwJj2jWrJqw dqiFWaR16Pf228eEGYq8Axq+xXeOY97a X-Received: by 10.13.212.70 with SMTP id w67mr19672100ywd.63.1497875466782; Mon, 19 Jun 2017 05:31:06 -0700 (PDT) MIME-Version: 1.0 Sender: jakub.php@gmail.com Received: by 10.129.182.39 with HTTP; Mon, 19 Jun 2017 05:31:06 -0700 (PDT) In-Reply-To: References: Date: Mon, 19 Jun 2017 13:31:06 +0100 X-Google-Sender-Auth: tshu0jmRUEsH44eTBpTZEme7bOw Message-ID: To: Fleshgrinder Cc: php-internals Content-Type: multipart/alternative; boundary="001a114fb5681daa8005524f4fb1" Subject: Re: [PHP-DEV] [RFC] [Vote] Doxygen From: bukka@php.net (Jakub Zelenka) --001a114fb5681daa8005524f4fb1 Content-Type: text/plain; charset="UTF-8" On Sat, Jun 17, 2017 at 8:53 AM, Fleshgrinder wrote: > Hi! > > I started voting on the Doxygen RFC: > > https://wiki.php.net/rfc/doxygen > > I just wanted to send my feedback and the reason why I voted "yes". First of all I don't really like adding too much documentation to the code (I'm actually talking about the PR which seems really too much IMHO). However I think that this RFC is more about having a standard for documenting exported functions which would be really good in my opinion and I think Doxygen is really good one (one can easily see that in Apache httpd for example). I think that few lines is usually enough and sometimes it is useful to have a note about the used parameters. What I want to say is that we shouldn't think about the RFC as accepting the proposed PR. It should be treated on case by case bases and over documented code should be still rejected. Cheers Jakub --001a114fb5681daa8005524f4fb1--